Skip to content

OCPBUGS-92924: CVE-2026-46597 openshift4/ose-hypershift-rhel9: golang.org/x/crypto/ssh: Denial of Service via crafted AES-GCM packet decoder inputs [openshift-4.19] - #9274

Open
tonyxrmdavidson wants to merge 1 commit into
openshift:release-4.19from
tonyxrmdavidson:OCPBUGS-92924-CVE-2026-46597-4-19
Open

Conversation

@tonyxrmdavidson

Copy link
Copy Markdown

Remediates CVE-2026-46597 (GHSA-q4h4-gmj2-qvw2, CVSS 7.5 High) — integer underflow in the AES-GCM packet decoder in
golang.org/x/crypto/ssh allowing remote DoS via crafted SSH packet.

Remediation Approach

Uses the OpenShift sustaining team's security-patched fork via replace directive to maintain compatibility with the release-4.19
dependency tree:

replace golang.org/x/crypto => github.com/openshift-sustaining/crypto v0.24.0-sec.2

Changes

  • go.mod — added replace directive for golang.org/x/crypto
  • go.sum — updated checksums for the fork
  • vendor/golang.org/x/crypto/ — vendored fork replaces upstream (ssh, poly1305, bcrypt, etc.)
  • vendor/modules.txt — updated module metadata
  • Changes are limited to golang.org/x/crypto vendored files only. No other dependencies were modified.

Build Results — PASS

All 6 binaries built successfully:

  • hypershift-operator — PASS
  • control-plane-operator — PASS
  • control-plane-pki-operator — PASS
  • karpenter-operator — PASS
  • hypershift (CLI) — PASS
  • hcp (product-cli) — PASS

Test Results — PASS

  • 133 test packages executed with race detection (-race)
  • 0 failures
  • All packages passed

Notes

  • The direct upgrade path (go get golang.org/x/crypto@v0.52.0) was not used for release-4.19 because it pulls in transitive dependency
    upgrades (x/net, x/sys, x/mod, x/term, x/text, x/tools) that may introduce compatibility risks on this stable branch.
  • The sustaining fork (github.com/openshift-sustaining/crypto@v0.24.0-sec.2) backports the security fix to a version compatible with
    release-4.19's dependency tree.

….org/x/crypto/ssh: Denial of Service via crafted AES-GCM packet decoder inputs [openshift-4.19]
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 10, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@tonyxrmdavidson: This pull request references Jira Issue OCPBUGS-92924, which is invalid:

  • expected dependent Jira Issue OCPBUGS-92954 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Remediates CVE-2026-46597 (GHSA-q4h4-gmj2-qvw2, CVSS 7.5 High) — integer underflow in the AES-GCM packet decoder in
golang.org/x/crypto/ssh allowing remote DoS via crafted SSH packet.

  • Branch: OCPBUGS-92924-CVE-2026-46597-4-19
  • Base: release-4.19 (5134322)
  • Jira: OCPBUGS-92924

Remediation Approach

Uses the OpenShift sustaining team's security-patched fork via replace directive to maintain compatibility with the release-4.19
dependency tree:

replace golang.org/x/crypto => github.com/openshift-sustaining/crypto v0.24.0-sec.2

Changes

  • go.mod — added replace directive for golang.org/x/crypto
  • go.sum — updated checksums for the fork
  • vendor/golang.org/x/crypto/ — vendored fork replaces upstream (ssh, poly1305, bcrypt, etc.)
  • vendor/modules.txt — updated module metadata
  • Changes are limited to golang.org/x/crypto vendored files only. No other dependencies were modified.

Build Results — PASS

All 6 binaries built successfully:

  • hypershift-operator — PASS
  • control-plane-operator — PASS
  • control-plane-pki-operator — PASS
  • karpenter-operator — PASS
  • hypershift (CLI) — PASS
  • hcp (product-cli) — PASS

Test Results — PASS

  • 133 test packages executed with race detection (-race)
  • 0 failures
  • All packages passed

Notes

  • The direct upgrade path (go get golang.org/x/crypto@v0.52.0) was not used for release-4.19 because it pulls in transitive dependency
    upgrades (x/net, x/sys, x/mod, x/term, x/text, x/tools) that may introduce compatibility risks on this stable branch.
  • The sustaining fork (github.com/openshift-sustaining/crypto@v0.24.0-sec.2) backports the security fix to a version compatible with
    release-4.19's dependency tree.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 95a82ba1-b736-46a4-9caa-16374ab9a5c6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Please specify an area label

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
openshift-ci Bot requested review from enxebre and sjenning August 10, 2026 20:11
@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tonyxrmdavidson
Once this PR has been reviewed and has the lgtm label, please assign jparrill for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tonyxrmdavidson

Copy link
Copy Markdown
Author

/test e2e-aws-techpreview

@tonyxrmdavidson

Copy link
Copy Markdown
Author

/test e2e-conformance

@tonyxrmdavidson

Copy link
Copy Markdown
Author

/pipeline required

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-techpreview
/test e2e-conformance

@openshift-ci

openshift-ci Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@tonyxrmdavidson: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/needs-area jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants