[release-4.21] OCPBUGS-104592: Add proxy env vars to AWS cloud-controller-manager deployment - #9224
Conversation
…r deployment The CCM deployment was missing HTTP_PROXY, HTTPS_PROXY, and NO_PROXY environment variables when the management cluster is configured with a proxy. This was a regression from the v1 to v2 component framework migration where the proxy.SetEnvVars() call was not carried over. Adapted for release-4.22: uses support/util instead of support/podspec (which doesn't exist on this branch). Adds the missing FindEnvVar helper to support/util/containers.go. Includes test coverage for full proxy, partial proxy (HTTP_PROXY-only and HTTPS_PROXY-only), no proxy, and env var preservation scenarios. This is a manual backport of PR openshift#9053 (commits ec5ae7a, 4afcef2) adapted for the release-4.22 branch.
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-100141 with correct target version. Will retitle the PR to link to the clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-104592, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@PoornimaSingour: This pull request references Jira Issue OCPBUGS-104592, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: muraee, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
Scheduling required tests: |
|
/verified by @vsolanki12 Verification: PR #9224 — Add proxy env vars to AWS CCM (release-4.21 backport)Unit TestsAll 4 test cases pass: Live Cluster TestingEnvironment:
Path A — No proxyCPO running without proxy env vars. CCM deployment has only AWS credential env vars: [
{"name": "AWS_SHARED_CREDENTIALS_FILE", "value": "/etc/kubernetes/secrets/cloud-provider/credentials"},
{"name": "AWS_SDK_LOAD_CONFIG", "value": "true"},
{"name": "AWS_EC2_METADATA_DISABLED", "value": "true"}
]Result: No HTTP_PROXY/HTTPS_PROXY/NO_PROXY injected — correct behavior when management cluster has no proxy. Path B — Proxy injectedResult: HTTP_PROXY, HTTPS_PROXY, and NO_PROXY correctly propagated to CCM container. NO_PROXY auto-appended kube-apiserver as expected by proxy.SetEnvVars(). |
|
@vsolanki12: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@vsolanki12: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4298ee0
into
openshift:release-4.21
|
@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-104592 Jira Issue OCPBUGS-104592 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira backport release-4.20 |
|
@PoornimaSingour: The following backport issues have been created:
Queuing cherrypicks to the requested branches to be created after this PR merges: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: new pull request created: #9284 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #9156
/assign openshift-ci-robot