Skip to content

Replace wildcard RBAC markers with explicit resource lists #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhiqiangf wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace wildcard RBAC markers with explicit resource lists #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee8b36c
FIND-003: Replace wildcard RBAC with explicit resource list
zhiqiangf Aug 6, 2026
dc07046
Regenerate bundle CSV to sync with updated RBAC and CRDs
zhiqiangf Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 33 additions & 9 deletions bundle/manifests/dpu-operator.clusterserviceversion.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ metadata:
}
]
capabilities: Basic Install
createdAt: "2025-12-17T09:38:34Z"
createdAt: "2026-08-06T17:22:37Z"
features.operators.openshift.io/cnf: "false"
features.operators.openshift.io/cni: "true"
features.operators.openshift.io/csi: "false"
Expand Down Expand Up @@ -103,6 +103,9 @@ spec:
kind: DataProcessingUnit
name: dataprocessingunits.config.openshift.io
version: v1
- kind: DpuNetwork
name: dpunetworks.config.openshift.io
version: v1
- description: DpuOperatorConfig is the Schema for the dpuoperatorconfigs API
displayName: Dpu Operator Config
kind: DpuOperatorConfig
Expand All @@ -127,8 +130,13 @@ spec:
- apiGroups:
- ""
resources:
- '*'
- configmaps
- persistentvolumeclaims
- persistentvolumes
- pods
- secrets
- serviceaccounts
- services
verbs:
- create
- delete
Expand All @@ -140,19 +148,32 @@ spec:
- apiGroups:
- ""
resources:
- persistentvolumeclaims
- persistentvolumes
- pods
- secrets
- services
- events
verbs:
- '*'
- create
- patch
- apiGroups:
- ""
resources:
- nodes
verbs:
- get
- list
- patch
- update
- watch
- apiGroups:
- admissionregistration.k8s.io
resources:
- mutatingwebhookconfigurations
verbs:
- '*'
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- apiextensions.k8s.io
resources:
Expand Down Expand Up @@ -180,6 +201,7 @@ spec:
resources:
- dataprocessingunitconfigs
- dataprocessingunits
- dpunetworks
- dpuoperatorconfigs
- servicefunctionchains
- servicefunctionchains/finalizers
Expand All @@ -196,6 +218,7 @@ spec:
resources:
- dataprocessingunitconfigs/finalizers
- dataprocessingunits/finalizers
- dpunetworks/finalizers
- dpuoperatorconfigs/finalizers
verbs:
- update
Expand All @@ -204,6 +227,7 @@ spec:
resources:
- dataprocessingunitconfigs/status
- dataprocessingunits/status
- dpunetworks/status
- dpuoperatorconfigs/status
- servicefunctionchains/status
verbs:
Expand Down
33 changes: 25 additions & 8 deletions config/rbac/role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,13 @@ rules:
- apiGroups:
- ""
resources:
- '*'
- configmaps
- persistentvolumeclaims
- persistentvolumes
- pods
- secrets
- serviceaccounts
- services
verbs:
- create
- delete
Expand All @@ -21,19 +25,32 @@ rules:
- apiGroups:
- ""
resources:
- persistentvolumeclaims
- persistentvolumes
- pods
- secrets
- services
- events
verbs:
- create
- patch
- apiGroups:
- ""
resources:
- nodes
verbs:
- '*'
- get
- list
- patch
- update
- watch
- apiGroups:
- admissionregistration.k8s.io
resources:
- mutatingwebhookconfigurations
verbs:
- '*'
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- apiextensions.k8s.io
resources:
Expand Down
10 changes: 5 additions & 5 deletions internal/controller/dataprocessingunit_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,12 @@ func (r *DataProcessingUnitReconciler) WithImagePullPolicy(policy string) *DataP
return r
}

// +kubebuilder:rbac:groups="",resources=pods,verbs=*
// +kubebuilder:rbac:groups="",resources=pods,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups="",resources=serviceaccounts,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups="",resources=secrets,verbs=*
// +kubebuilder:rbac:groups="",resources=services,verbs=*
// +kubebuilder:rbac:groups="",resources=persistentvolumeclaims,verbs=*
// +kubebuilder:rbac:groups="",resources=persistentvolumes,verbs=*
// +kubebuilder:rbac:groups="",resources=secrets,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups="",resources=services,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups="",resources=persistentvolumeclaims,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups="",resources=persistentvolumes,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups=apps,resources=daemonsets,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups=apps,resources=deployments,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups=apps,resources=replicasets,verbs=get;list;watch;create;update;patch;delete
Expand Down
16 changes: 9 additions & 7 deletions internal/controller/dpuoperatorconfig_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,14 +81,16 @@ func (r *DpuOperatorConfigReconciler) WithImagePullPolicy(policy string) *DpuOpe
//+kubebuilder:rbac:groups=config.openshift.io,resources=servicefunctionchains,verbs=get;list;watch;create;update;patch;delete
//+kubebuilder:rbac:groups=config.openshift.io,resources=servicefunctionchains/status,verbs=get;update;patch
//+kubebuilder:rbac:groups=config.openshift.io,resources=servicefunctionchains/finalizers,verbs=create;delete;get;list;patch;update;watch
//+kubebuilder:rbac:groups="",resources=*,verbs=get;list;watch;create;update;patch;delete
//+kubebuilder:rbac:groups="",resources=persistentvolumeclaims,verbs=*
//+kubebuilder:rbac:groups="",resources=persistentvolumes,verbs=*
//+kubebuilder:rbac:groups="",resources=pods,verbs=*
//+kubebuilder:rbac:groups="",resources=secrets,verbs=*
//+kubebuilder:rbac:groups="",resources=configmaps,verbs=get;list;watch;create;update;patch;delete
//+kubebuilder:rbac:groups="",resources=serviceaccounts,verbs=get;list;watch;create;update;patch;delete
//+kubebuilder:rbac:groups="",resources=services,verbs=*
//+kubebuilder:rbac:groups=admissionregistration.k8s.io,resources=mutatingwebhookconfigurations,verbs=*
//+kubebuilder:rbac:groups="",resources=services,verbs=get;list;watch;create;update;patch;delete
//+kubebuilder:rbac:groups="",resources=secrets,verbs=get;list;watch;create;update;patch;delete
//+kubebuilder:rbac:groups="",resources=pods,verbs=get;list;watch;create;update;patch;delete
//+kubebuilder:rbac:groups="",resources=nodes,verbs=get;list;watch;update;patch
//+kubebuilder:rbac:groups="",resources=persistentvolumeclaims,verbs=get;list;watch;create;update;patch;delete
//+kubebuilder:rbac:groups="",resources=persistentvolumes,verbs=get;list;watch;create;update;patch;delete
//+kubebuilder:rbac:groups="",resources=events,verbs=create;patch
//+kubebuilder:rbac:groups=admissionregistration.k8s.io,resources=mutatingwebhookconfigurations,verbs=get;list;watch;create;update;patch;delete
//+kubebuilder:rbac:groups=apiextensions.k8s.io,resources=customresourcedefinitions,verbs=get;list;watch
//+kubebuilder:rbac:groups=apps,resources=daemonsets,verbs=get;list;watch;create;update;patch;delete
//+kubebuilder:rbac:groups=apps,resources=deployments,verbs=get;list;watch;create;update;patch;delete
Expand Down
42 changes: 33 additions & 9 deletions manifests/stable/dpu-operator.clusterserviceversion.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ metadata:
}
]
capabilities: Basic Install
createdAt: "2025-12-17T09:38:34Z"
createdAt: "2026-08-06T17:22:37Z"
features.operators.openshift.io/cnf: "false"
features.operators.openshift.io/cni: "true"
features.operators.openshift.io/csi: "false"
Expand Down Expand Up @@ -103,6 +103,9 @@ spec:
kind: DataProcessingUnit
name: dataprocessingunits.config.openshift.io
version: v1
- kind: DpuNetwork
name: dpunetworks.config.openshift.io
version: v1
- description: DpuOperatorConfig is the Schema for the dpuoperatorconfigs API
displayName: Dpu Operator Config
kind: DpuOperatorConfig
Expand All @@ -127,8 +130,13 @@ spec:
- apiGroups:
- ""
resources:
- '*'
- configmaps
- persistentvolumeclaims
- persistentvolumes
- pods
- secrets
- serviceaccounts
- services
verbs:
- create
- delete
Expand All @@ -140,19 +148,32 @@ spec:
- apiGroups:
- ""
resources:
- persistentvolumeclaims
- persistentvolumes
- pods
- secrets
- services
- events
verbs:
- '*'
- create
- patch
- apiGroups:
- ""
resources:
- nodes
verbs:
- get
- list
- patch
- update
- watch
- apiGroups:
- admissionregistration.k8s.io
resources:
- mutatingwebhookconfigurations
verbs:
- '*'
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- apiextensions.k8s.io
resources:
Expand Down Expand Up @@ -180,6 +201,7 @@ spec:
resources:
- dataprocessingunitconfigs
- dataprocessingunits
- dpunetworks
- dpuoperatorconfigs
- servicefunctionchains
- servicefunctionchains/finalizers
Expand All @@ -196,6 +218,7 @@ spec:
resources:
- dataprocessingunitconfigs/finalizers
- dataprocessingunits/finalizers
- dpunetworks/finalizers
- dpuoperatorconfigs/finalizers
verbs:
- update
Expand All @@ -204,6 +227,7 @@ spec:
resources:
- dataprocessingunitconfigs/status
- dataprocessingunits/status
- dpunetworks/status
- dpuoperatorconfigs/status
- servicefunctionchains/status
verbs:
Expand Down