WIP: Bump Go toolchain to 1.26 and pin protobuf - #486
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
WalkthroughThe builder image now uses Go 1.26. The indirect ChangesBuild toolchain updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Mergeability Score: ⚪ Minimal · up to The changes update the Go toolchain and protobuf dependency metadata without a demonstrated correctness, security, or availability issue; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5 | ❌ 10❌ Failed checks (10 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 14 UNAVAILABLE: Connection dropped Comment |
|
@Prashanth684: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
🔇 Additional comments (2)
Dockerfile (1)
1-1: 🔒 Security & Privacy
⚠️ Unverified finding
Sandbox verification was unavailable.Verify the final image contract after changing the builder image.
Line 1 uses a floating tag for the builder image. This is consistent with the container path policy for Red Hat images. The selected range does not show the final stage. Verify that the final image excludes build tools, runs as non-root, uses a read-only root filesystem where possible, and defines
HEALTHCHECK.As per path instructions, the matching container rules require “Multi-stage builds; no build tools in final image; USER non-root; never run as root; Read-only rootfs where possible; HEALTHCHECK defined.”
go.mod (1)
74-74: 🔒 Security & Privacy
⚠️ Unverified finding
Sandbox verification was unavailable.Verify release controls for the protobuf update.
The supplied context pins the exact pseudo-version and includes matching
go.sumchecksums. The two relevant OSV records list fixes at1.33.0and1.29.1; this1.36.12-based pseudo-version is newer than those affected ranges. (osv.dev)The provided files do not show SBOM generation, provenance attestations, or Sigstore/cosign signing. Verify that the build pipeline still enables these controls.
As per path instructions, the matching supply-chain rules require “Pin exact versions; verify hashes where supported; SBOM: ensure build produces provenance attestations; Signing: artifacts signed with Sigstore/cosign.”
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 461d59b7-590d-496e-b38e-af559a7bdc33
⛔ Files ignored due to path filters (19)
go.sumis excluded by!**/*.sumvendor/google.golang.org/protobuf/encoding/protodelim/protodelim.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/encoding/prototext/decode.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/internal/descfmt/stringer.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/internal/encoding/tag/tag.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/internal/encoding/text/decode.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/internal/filedesc/desc.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/internal/filedesc/desc_init.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/internal/filedesc/desc_lazy.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/internal/filedesc/editions.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/internal/genid/descriptor_gen.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/internal/impl/codec_map.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/internal/impl/decode.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/internal/impl/validate.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/internal/version/version.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/proto/decode.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/types/descriptorpb/descriptor.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/google.golang.org/protobuf/types/known/timestamppb/timestamp.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/modules.txtis excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (2)
Dockerfilego.mod
Summary by CodeRabbit