Preserve authentication for self-referential CCS - #6474
Merged
willyborankin merged 2 commits intoSep 14, 2026
Merged
Conversation
Contributor
PR Reviewer Guide 🔍(Review updated until commit 7427efb)Here are some key observations to aid the review process:
|
Identify direct local requests using the TransportService connection instead of relying on DiscoveryNode equality. This ensures remote TCP requests targeting the same node serialize their user context. Signed-off-by: Craig Perkins <craig5008@gmail.com>
cwperks
force-pushed
the
fix/ccs-self-remote-auth
branch
from
September 5, 2026 12:34
813bfbb to
1815de0
Compare
Contributor
|
Persistent review updated to latest commit 1815de0 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6474 +/- ##
==========================================
+ Coverage 75.88% 75.93% +0.05%
==========================================
Files 459 459
Lines 30619 30619
Branches 4602 4602
==========================================
+ Hits 23234 23251 +17
+ Misses 5265 5248 -17
Partials 2120 2120
🚀 New features to boost your workflow:
|
cwperks
marked this pull request as ready for review
September 8, 2026 11:44
cwperks
requested review from
DarshitChanpura,
Rishav9852Kumar,
RyanL1997,
derek-ho,
finnegancarroll,
nibix,
reta,
shikharj05 and
willyborankin
as code owners
September 8, 2026 11:44
willyborankin
approved these changes
Sep 14, 2026
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Contributor
|
Persistent review updated to latest commit 7427efb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5846
Summary
DiscoveryNodeinstance rather thanDiscoveryNode.equalsDiscoveryNodeequals, but is not identical to, the local nodeValidation
./gradlew spotlessJavaCheck test --tests org.opensearch.security.transport.SecurityInterceptorTests --tests org.opensearch.security.transport.RestoringTransportResponseHandlerTestsNote
./gradlew precommitreaches an unrelated existing forbidden-API failure in the sample resource plugin forURL.openStream()