Skip to content

Rename resource sharing feature flag to the non-experimental key - #1815

Merged
riysaxen-amzn merged 1 commit into
opensearch-project:mainfrom
DarshitChanpura:graduate/resource-sharing-non-experimental
Sep 15, 2026
Merged

riysaxen-amzn merged 1 commit into
opensearch-project:mainfrom
DarshitChanpura:graduate/resource-sharing-non-experimental

Conversation

@DarshitChanpura

@DarshitChanpura DarshitChanpura commented Sep 15, 2026 •

Copy link
Copy Markdown
Member

Description

Resource sharing graduates out of experimental in opensearch-project/security#6348, which drops the experimental. segment from the feature-flag settings with no deprecated fallback:

Before After
plugins.security.experimental.resource_sharing.enabled plugins.security.resource_sharing.enabled
plugins.security.experimental.resource_sharing.protected_types plugins.security.resource_sharing.protected_types

Updates the integTest cluster settings in build.gradle to the new keys.

Only the setting strings change. The ConfigConstants constant names (OPENSEARCH_RESOURCE_SHARING_ENABLED, OPENSEARCH_RESOURCE_SHARING_PROTECTED_TYPES) are unchanged, so no Java/Kotlin references are affected. The gradle -Dresource_sharing.enabled system property that gates the resource-sharing CI matrix is a separate toggle and is left as is.

Because the rename has no fallback, the security integTest jobs here will fail to start a node (unknown setting [plugins.security.resource_sharing.enabled]) until a new 3.9 security snapshot publishes. Security PR 6348 is merged, so that republish is the only remaining gate; this needs to land in 3.9 with it.

Related Issues

Companion to opensearch-project/security#6348. Related to opensearch-project/security#4500

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Resource sharing graduates out of experimental in
opensearch-project/security#6348, which drops the experimental. segment
from the feature-flag settings with no deprecated fallback:

  plugins.security.experimental.resource_sharing.enabled
    -> plugins.security.resource_sharing.enabled
  plugins.security.experimental.resource_sharing.protected_types
    -> plugins.security.resource_sharing.protected_types

Updates the integTest cluster settings to the new keys.

Only the setting strings change. The ConfigConstants constant names
(OPENSEARCH_RESOURCE_SHARING_ENABLED, OPENSEARCH_RESOURCE_SHARING_PROTECTED_TYPES)
are unchanged, so no Java/Kotlin references are affected. The gradle
-Dresource_sharing.enabled system property that gates the CI matrix is a
separate toggle and is left as is.

Verified no occurrence of the old key remains anywhere in the repo.

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.44%. Comparing base (e3ec711) to head (25a77e5).

❌ Your project check has failed because the head coverage (68.44%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1815      +/-   ##
============================================
- Coverage     68.60%   68.44%   -0.17%     
+ Complexity     3751     3749       -2     
============================================
  Files           417      417              
  Lines         20888    20888              
  Branches       2189     2189              
============================================
- Hits          14331    14297      -34     
- Misses         5457     5492      +35     
+ Partials       1100     1099       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@riysaxen-amzn

Copy link
Copy Markdown
Collaborator

Approving. Verified against the PR head:

Good to merge once the security integTest jobs pick up a 3.8 snapshot containing 6348.

@riysaxen-amzn
riysaxen-amzn merged commit 9aa1f0c into opensearch-project:main Sep 15, 2026
19 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants