Deprecate filter_by_backend_roles, targeting removal in 4.0 - #1490
Open
DarshitChanpura wants to merge 3 commits into
Open
DarshitChanpura wants to merge 3 commits into
DarshitChanpura wants to merge 3 commits into
Conversation
Backend-role filtering is superseded by the security plugin's resource sharing and access control, which authorizes a resource by the access level it is shared at rather than by backend-role overlap. Workflows and workflow state are onboarded to resource sharing, so the setting is now the legacy path. - plugins.flow_framework.filter_by_backend_roles gets Setting.Property.Deprecated - javadoc names 4.0 as the removal target and the replacement Verified by compiling; the test task cannot run on this branch because testRuntimeClasspath resolution fails on main with conflicting jackson-databind and httpclient5 versions, which reproduces with this change stashed. Tracking: opensearch-project/security#6530 Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
requested review from
amitgalitz,
dbwiddis,
jackiehanyang,
joshpalis,
junweid62,
ohltyler and
owaiskazi19
as code owners
September 18, 2026 19:03
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Contributor
PR Reviewer Guide 🔍(Review updated until commit 356f368)Here are some key observations to aid the review process:
|
Contributor
|
Persistent review updated to latest commit f61c14b |
dbwiddis
approved these changes
Sep 18, 2026
Contributor
|
Persistent review updated to latest commit f61c14b |
ohltyler
approved these changes
Sep 28, 2026
Contributor
|
Persistent review updated to latest commit 356f368 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Marks backend-role filtering deprecated, targeting removal in 4.0. It is superseded by the security plugin's resource sharing and access control, which authorizes a resource by the access level it is shared at rather than by backend-role overlap, and both
workflowandworkflow_stateare already onboarded.plugins.flow_framework.filter_by_backend_rolesgetsSetting.Property.DeprecatedNo behavior change:
Property.Deprecatedonly emits a deprecation warning when the setting is set.Testing
compileJavais clean. Thetesttask cannot run on this branch:testRuntimeClasspathresolution fails with conflictingjackson-databind(3.2.1 against 3.2.2) andhttpclient5(5.6.1 against 5.6.4) versions. That reproduces with this change stashed, so it is a pre-existing issue onmainrather than something this PR introduces. CI will exercise the suite once resolution is fixed.Related
Tracking issue: opensearch-project/security#6530
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.