Drop support for legacy Python versions#407
Conversation
abc8124 to
9287068
Compare
There was a problem hiding this comment.
The changes look fine; thanks for this.
Before we merge this, is it worth considering a final <3.10 supporting release with a check of the Python version at startup, and a warning if the Python version is <3.10?
The warning might state something like:
The installed Python version being used to run the OpenSAFELY CLI is older than Python 3.10 and now end-of-life.
This installed version of OpenSAFELY CLI will continue to run, but you will no longer receive new versions of the OpenSAFELY CLI.
Please upgrade your Python installation to ensure you can upgrade to new versions of the OpenSAFELY CLI.
It's fine if the answer is "no", but I'm not sure if this idea has been discussed anywhere before.
|
thought: I would really like for us to go to further on this, but also concede that this is a reasonable and low risk improvement for now. That's since:
But #280 was only scoped to the end-of-life versions incrementally. So for now, I'll happily take a more regular maintenance cycle in line with Python end-of-life. Maybe other ideas like using Doing this as a hopefully minimally disruptive upgrade with few users affected gets us some way towards modernising our users' installations, and figuring out how best to conduct these upgrade cycles. |
|
@StevenMaude yes I think moving the uv and getting off 3.10 before the end of its life cycle should be the next steps. |
Now that we have updated to a modern version of Ruff
dd2a3ae to
c22ff54
Compare
4e44b8c to
a055f4f
Compare
a055f4f to
108f069
Compare
Part of #280
This PR removes support in OpenSAFELY CLI for Python v3.8 and v3.9. As we are now updating to use 3.10, we take the opportunity to bump our dependencies, meaning we can also remove
blackand replace it withruff- as we have in other repos.This PR does not include
just update-vendored-dependenciesas that is a RAP task.Changes
Now that we have updated to a modern version of Ruff
just fixto update syntax for Ruff