Repository navigation
feat: add Codex agent #161
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| // Copyright (C) 2026 Red Hat, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| use super::Agent; | ||
|
|
||
| pub struct CodexAgent; | ||
|
|
||
| impl Agent for CodexAgent { | ||
| fn id(&self) -> &str { | ||
| "codex" | ||
| } | ||
|
|
||
| fn install(&self) -> String { | ||
| "RUN curl -fsSL https://chatgpt.com/codex/install.sh | sh\nENV PATH=/sandbox/.local/bin:$PATH" | ||
| .to_string() | ||
| } | ||
|
|
||
| fn binary_path(&self) -> &str { | ||
| "/sandbox/.local/bin/codex" | ||
| } | ||
| } | ||
|
There was a problem hiding this comment. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win Implement model configuration. After OpenAI support is enabled, 🤖 Prompt for AI Agents🎯 Functional Correctness | 🟠 Major | ⚡ Quick win Implement the endpoint environment variable. After OpenAI support is enabled, 🤖 Prompt for AI Agents |
||
|
|
||
| #[cfg(test)] | ||
| mod tests { | ||
| use super::*; | ||
|
|
||
| #[test] | ||
| fn agent_id_is_codex() { | ||
| assert_eq!(CodexAgent.id(), "codex"); | ||
| } | ||
|
|
||
| #[test] | ||
| fn install_is_nonempty() { | ||
| assert!(!CodexAgent.install().is_empty()); | ||
| } | ||
|
|
||
| #[test] | ||
| fn install_contains_codex_installer() { | ||
| assert!( | ||
| CodexAgent | ||
| .install() | ||
| .contains("https://chatgpt.com/codex/install.sh") | ||
| ); | ||
| } | ||
|
|
||
| #[test] | ||
| fn install_adds_local_bin_to_path() { | ||
| assert!( | ||
| CodexAgent | ||
| .install() | ||
| .contains("ENV PATH=/sandbox/.local/bin:$PATH") | ||
| ); | ||
| } | ||
|
|
||
| #[test] | ||
| fn binary_path_is_local_bin_codex() { | ||
| assert_eq!(CodexAgent.binary_path(), "/sandbox/.local/bin/codex"); | ||
| } | ||
|
|
||
| #[test] | ||
| fn skills_dir_is_empty() { | ||
| assert_eq!(CodexAgent.skills_dir(), ""); | ||
| } | ||
|
|
||
| #[test] | ||
| fn skip_onboarding_is_noop() { | ||
| let mut files = std::collections::HashMap::new(); | ||
| files.insert("some.json".to_string(), "content".to_string()); | ||
| let result = CodexAgent.skip_onboarding(files.clone()); | ||
| assert_eq!(result, files); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Declare OpenAI inference support.
CodexAgentinheritssupported_inference(), which returns an empty vector.src/main.rs::runtherefore rejects--agent codex --inference openaibefore building an image. Every new positive Codex image test uses this combination. Override the method to return onlyInferenceKind::OpenAi. (raw.githubusercontent.com)Proposed fix
impl Agent for CodexAgent { + fn supported_inference(&self) -> Vec<crate::inference::InferenceKind> { + vec![crate::inference::InferenceKind::OpenAi] + } +📝 Committable suggestion
🤖 Prompt for AI Agents