Skip to content

fix: feed_api_key field doesn't show its "stored" state after masking #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rjonesbsink wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −3
Open

fix: feed_api_key field doesn't show its "stored" state after masking #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions assets/js/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6071,17 +6071,36 @@
var input = document.getElementById('setFeedApiKey');
var banner = document.getElementById('feedKeyMissingBanner');
if (!input || !banner) return;
if (input.value.trim() === '') {
banner.classList.remove('d-none');
} else {
// feed_api_key is a data-secret field: a blank value on load doesn't
// mean "not configured", it means "stored, not shown". Trust the
// configured flag set by loadApiKeys() unless the admin has typed
// a new value this session.
var hasTypedValue = input.value.trim() !== '';
var isConfigured = input.dataset.configured === '1';
if (hasTypedValue || isConfigured) {
banner.classList.add('d-none');
} else {
banner.classList.remove('d-none');
}
}

function loadApiKeys() {
apiGet('settings').then(function (data) {
var settings = data.settings || {};
applySettingsToForm(document.getElementById('apiKeysForm'), settings);
// feed_api_key is data-secret — the server never sends the real
// value, only a feed_api_key_set boolean. applySettingsToForm
// can't fill a field it wasn't given a value for, so handle the
// placeholder here (same "stored / not set" pattern as Slack's
// secret fields).
var feedInput = document.getElementById('setFeedApiKey');
if (feedInput) {
feedInput.value = '';
feedInput.dataset.configured = settings.feed_api_key_set ? '1' : '0';
feedInput.placeholder = settings.feed_api_key_set
? '•••• stored — leave blank to keep, type to replace'
: '(empty — feed disabled)';
}
updateFeedKeyBanner();
}).catch(function (err) {
showAlert('Failed to load API keys: ' + err.message, 'danger');
Expand Down
Loading