Skip to content

Add SYSGO IP card links, review content of SYSGO-related IPs. - #183

Merged
cairo-caplan merged 6 commits into
openhwfoundation:mainfrom
HolgerBlasumSYSGO:main
Oct 7, 2026
Merged

cairo-caplan merged 6 commits into
openhwfoundation:mainfrom
HolgerBlasumSYSGO:main

Conversation

@HolgerBlasumSYSGO

Copy link
Copy Markdown
Contributor

Added links to SYSGO IP cards, reviewed content of SYSGO-related IPs in TRISTAN, ISOLDE and REBECCA.

@cairo-caplan cairo-caplan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the updates, @HolgerBlasumSYSGO !

I am merging it

@HolgerBlasumSYSGO

Copy link
Copy Markdown
Contributor Author

Hi Cairo, I tried to resolve it, by accepting the other incoming change request over mine (to be a polite person). If easier for you, you can abort this request and I make a new one.

@HolgerBlasumSYSGO

Copy link
Copy Markdown
Contributor Author

Hi Cairo, this still fails on: - 11.IP_CARD_PDF_URL: 'N/A' is not a 'ip_card_pdf'

  • 11.IP_CARD_URL: 'N/A' is not a 'ip_card_json'
  • 14.IP_CARD_PDF_URL: 'N/A' is not a 'ip_card_pdf'
  • 14.IP_CARD_URL: 'N/A' is not a 'ip_card_json'
  • 18.IP_CARD_PDF_URL: 'N/A' is not a 'ip_card_pdf'
  • 18.IP_CARD_URL: 'N/A' is not a 'ip_card_json'. Can you change the validation script to accept "N/A". These are not "my" IPs but other partners filled it like that and I don't want to delete that.

@HolgerBlasumSYSGO

Copy link
Copy Markdown
Contributor Author

Ok, now its passing again.

@cairo-caplan
cairo-caplan merged commit 0a053a9 into openhwfoundation:main Oct 7, 2026
2 checks passed
@cairo-caplan

Copy link
Copy Markdown
Collaborator

Hi again @HolgerBlasumSYSGO
I (re)added manually the entry for the OpenEMS demo setup. It was present during my first review of this PR ( https://github.com/openhwfoundation/uap/pull/183/files/c23f4340de4d65dc58ff99400cc2f3f7e62215c7 ), but somehow it got lost during the merge conflict resolution. So, I am letting you know

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants