chore(ci): correct release-please retargeting, targeting, and java snapshot#605
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThis PR updates the release-please CI/CD system with GitHub App client-id authentication (v3.2.0), migrates PR discovery from search-based to REST API pagination for stale closure and retargeting, adds component-scoped PR closure when targeting single packages, and configures the Java package to skip snapshot releases. ChangesRelease Please Workflow and Configuration Updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the release automation configuration to better handle release-please behavior across multiple packages, including Java snapshot handling and workflow retargeting/targeting logic.
Changes:
- Configure Java release-please package to skip snapshot PRs (
skip-snapshot: true). - Update the reusable release-please workflow to use REST API listing (instead of
gh pr list --search) to avoid GitHub search indexing lag. - Add logic to close non-target package release PRs during a targeted dispatch retargeting flow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
release-please-config.json |
Adds Java skip-snapshot configuration for release-please. |
.github/workflows/reusable-release-please.yaml |
Adjusts release-please PR discovery/retargeting logic and updates GitHub App token action inputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/reusable-release-please.yaml:
- Around line 217-226: The current logic that calls gh api PATCH
"repos/${GITHUB_REPOSITORY}/pulls/${pr}" -f head="${new_head}" (inside the block
where new_head != head) attempts to mutate a PR's read-only head and then
deletes the old branch; change this to a supported flow: when you recreate the
branch (after git push origin "${sha}:refs/heads/${new_head}"), do not call
PATCH to set head, instead either (A) create a new PR from ${new_head} and close
the old PR (use gh api to POST a new pull and PATCH the old PR to state=closed),
or (B) keep the old branch until you verify the PR now points to the recreated
ref by checking the PR's head via gh api and only delete the old branch if the
PR head matches; remove the unsupported PATCH call and the unconditional git
push origin --delete "${head}" that can orphan the PR.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 61e2c4c8-bad6-4462-a5da-d5e6b58c163e
📒 Files selected for processing (2)
.github/workflows/reusable-release-please.yamlrelease-please-config.json
9b9b549 to
a23d018
Compare
a23d018 to
28403c4
Compare
Description
Updated workflow to use clientID instead of deprecated APP ID
And added java snapshot config
What problem is being solved?
How is it being solved?
What changes are made to solve it?
References
Review Checklist
mainSummary by CodeRabbit