Skip to content

fix: add animation frame for submitting answers after problem reset #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bra-i-am wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add animation frame for submitting answers after problem reset #303

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c9edc8
fix: add animation frame for submitting answers after problem reset
bra-i-am Sep 17, 2026
abe1926
docs: add a commet to explain the change
bra-i-am Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions xblocks_contrib/problem/assets/static/js/display.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,6 +639,14 @@ Problem.prototype.reset_internal = function () {
that.el.trigger("contentChanged", [that.id, response.html, response]);
that.render(response.html, that.scroll_to_problem_meta);
that.updateProgress(response);
// After reset, bind() calls submitAnswersAndSubmitButton() synchronously, but
// browsers cache the checked state of new inputs by name/id before repainting
// so :checked still returns true on fresh inputs and the button stays enabled.
// requestAnimationFrame defers the check until after the repaint, when the
// stale form state is gone and the button is correctly disabled.
window.requestAnimationFrame(function () {
that.submitAnswersAndSubmitButton();
});
return window.SR.readText(gettext("This problem has been reset."));
} else {
return that.gentle_alert(response.msg);
Expand Down