feat: add SupportEnrollmentDataRequested filter - #393
Conversation
b1af155 to
1d1fa1d
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
1d1fa1d to
c0a3d1c
Compare
Adds a filter that lets pipeline steps inject enterprise enrollment data into the support enrollment lookup view. run_filter returns a tuple of all its inputs (enrollment_data, user), matching the convention used by every other filter in this module (per pwnage101's review feedback on the sibling SupportContactContextRequested filter in PR openedx#390). Includes unit tests. ENT-11574
c0a3d1c to
4a1172e
Compare
|
@pwnage101 addressed both docstring suggestions in the latest commit — dropped the "with additional enrollment records" framing from the class summary, and reworded the Purpose paragraph to say pipeline steps can inject new records or augment existing ones, rather than implying additive-only enrichment. CI is green. |
Please delete all this highlighted text from the commit message, it's just more irrelevant information containing a history of past conversions. |
pwnage101
left a comment
pwnage101
left a comment
There was a problem hiding this comment.
LGTM, just simplify that commit message
2 participants
ENT-11574
Companion PR to the already-open support-contact-tag PR set (openedx-filters#390,
edx-enterprise#2688, openedx-platform#39076, edx-platform#455) — this one covers the
other half of ENT-11574's acceptance criteria: enterprise enrollment data for the support
enrollment view.
Adds
SupportEnrollmentDataRequested(org.openedx.learning.support.enrollment.data.requested.v1)— lets pipeline steps inject enterprise enrollment data into the support enrollment lookup.
Related PRs
openedx-platform#39076, edx-platform#455 (support-contact-tag)
Testing
New: unit tests for the filter class in
openedx_filters/learning/tests/test_filters.py,matching the existing per-filter-class test pattern.
Locally verified:
pytest openedx_filters/learning/tests/test_filters.py— 75 passed.mypyclean.
isort --check-onlyclean.Changelog / version
Bumped
__version__to3.11.0(3.10.0 already claimed by the sibling contact-tag PR) andadded a
CHANGELOG.rstentry, matching current practice.