Conversation
|
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3246 +/- ##
=======================================
Coverage 96.03% 96.03%
=======================================
Files 1407 1407
Lines 34287 34297 +10
Branches 7882 7888 +6
=======================================
+ Hits 32928 32938 +10
Misses 1318 1318
Partials 41 41 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
BryanttV
left a comment
There was a problem hiding this comment.
I tested these changes on my local and they work correctly. I used various role types and course and library assignments, and the link is displayed or not depending on the user's permissions. LGTM!
Description
When a unit comes from a Library, the Unit overview displays an alert with a link that redirects to the unit's page in library authoring (
upstreamInfo.upstreamLink). That link was shown to everyone, including users who have no access to the source library, who then land on a page they are not allowed to see.This PR shows the link only when the current user has
content_libraries.view_libraryon the source library:For that:
useUserPermissionsdirectly, understanding thatopenedx-authzis enable by default in libraries scope.upstreamRef.Supporting information
Part of the fine-grained permissions (openedx-authz) work for course authoring. It closes openedx/openedx-authz#450
Testing instructions
Testing instructions
openedx-authzenabled.Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'