fix: use route-level lazy to avoid suspending on soft navigation - #233
Merged
Merged
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #233 +/- ##
=======================================
Coverage 98.53% 98.53%
=======================================
Files 73 73
Lines 1295 1297 +2
Branches 394 394
=======================================
+ Hits 1276 1278 +2
Misses 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
🎉 This PR is included in version 1.0.0-alpha.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Loads the main route component with react-router's route-level
lazy()instead ofReact.lazy, so the router awaits the chunk during navigation. WithReact.lazy, client-side navigation into the app (e.g. from the Instructor Dashboard's "View Studio Roles" button, made a soft navigation by openedx/frontend-app-instructor-dashboard#246) suspends synchronously with no Suspense boundary, logging "A component suspended while responding to synchronous input" and flashing the UI. Hard navigation was unaffected, which is why this never surfaced before.LLM usage notice
Built with assistance from Claude.