fix: include the /admin-console prefix in the app's route path - #232
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #232 +/- ##
=======================================
Coverage 98.53% 98.53%
=======================================
Files 73 73
Lines 1294 1295 +1
Branches 423 424 +1
=======================================
+ Hits 1275 1276 +1
Misses 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Frontend-base sites mount app routes verbatim, so the app must declare its own URL prefix instead of relying on a site basename. Co-Authored-By: Claude <noreply@anthropic.com>
arbrandes
force-pushed
the
arbrandes/fix-route-prefix
branch
from
September 20, 2026 12:10
22b7c45 to
43e2211
Compare
Collaborator
|
🎉 This PR is included in version 1.0.0-alpha.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The admin console route was declared as
/authz/*, relying on abasename: '/admin-console'in the site configs. That works standalone,but in a unified frontend-base site (such as the one built by tutor-mfe,
which links to
{MFE_HOST}/admin-console/authz/...) app routes aremounted verbatim under the site root, so those URLs rendered a 404.
Declare the full
/admin-console/authz/*path in the route instead, asauthn and learner-dashboard already do, and drop the basename from the
dev, CI, and test site configs. Consolidate the absolute base path into
AUTHZ_HOME_PATH, make the nested route segments visibly relative, andadd a
buildAuditUserPath()helper so internal navigation no longerhand-assembles paths. Standalone URLs are unchanged.
Companion to openedx/frontend-app-gradebook#626.
LLM usage notice
Built with assistance from Claude.