fix: drop broken i18n export from the package index - #231
Merged
Merged
Conversation
The atlas-generated messages module is not published to npm, so re-exporting it broke webpack builds in consuming sites. Co-Authored-By: Claude <noreply@anthropic.com>
The test raced a 5000ms auto-dismiss against a 5050ms waitFor timeout, which flaked on slow CI runners. Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #231 +/- ##
=======================================
Coverage 98.53% 98.53%
=======================================
Files 73 73
Lines 1294 1294
Branches 423 423
=======================================
Hits 1275 1275
Misses 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
🎉 This PR is included in version 1.0.0-alpha.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
src/index.tsre-exported./i18n, which in turn re-exports the atlas-generatedsrc/i18n/messagesmodule. That module is gitignored and not generated duringprepack, so the published tarball'sdist/i18n/index.jspoints at a file that doesn't exist. Webpack then fails to resolve./messagesin any site that depends on the package, even if it only importsadminConsoleApp.Sites get translations via their own
translations:pull(atlas) step, not from package exports, so the export is unnecessary. Dropping it matches frontend-app-learner-dashboard.LLM usage notice
Built with assistance from Claude.