fix: clear email during user retirement - #3003
Merged
Merged
Conversation
naincy128
force-pushed
the
upstream/LP-959
branch
from
August 28, 2026 08:32
899e592 to
44adbf0
Compare
naincy128
force-pushed
the
upstream/LP-959
branch
from
August 28, 2026 08:35
44adbf0 to
9e166d4
Compare
santhosh-apphelix-2u
approved these changes
Aug 28, 2026
naincy128
requested review from
GlugovGrGlib,
bmtcril and
deborahgu
and removed request for
bmtcril
August 28, 2026 08:49
mraman-2U
approved these changes
Aug 28, 2026
bmtcril
reviewed
Aug 28, 2026
| return False | ||
| return True | ||
|
|
||
| def _replace_username_for_all_models(self, current_username, new_username, replacement_locations): |
Contributor
There was a problem hiding this comment.
nit: It would be good to rename this to more closely match what's happening in here
bmtcril
reviewed
Aug 28, 2026
bmtcril
left a comment
bmtcril
left a comment
Contributor
There was a problem hiding this comment.
Just one nit, otherwise looks good to me.
deborahgu
enabled auto-merge (squash)
August 28, 2026 20:22
deborahgu
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the Credentials service user retirement flow did not fully anonymize retired users email.
Changes
Clear the email field during the user retirement process.
Ticket
LP-959