Feature/add new project components endpoint#51
Open
ivan-risueno wants to merge 10 commits into
Open
Conversation
added 6 commits
June 15, 2026 14:01
sergio-soria-bi
requested changes
Jun 17, 2026
| if (!validateTokenPermittedOids(accessToken)) { | ||
| throw new ForbiddenException("Invalid caller. Please, provide a valid token within the request."); | ||
| } | ||
| if (page < 0 || size < 0 || size > 100) { |
Contributor
There was a problem hiding this comment.
does it make sense to make size configurable?
I can see it useful for testing, for instance
Contributor
Author
There was a problem hiding this comment.
It does, since we cannot ensure network stability or good latency. Also, we should let our callers to retrieve the amount of data per call that they want to, up to a certain limit. That's my point of view though, discussions are more than accepted 😊
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.