Repository navigation
Fix securityservices.proto compilation issue and add CI protoc check - #31
Merged
Merged
Conversation
protoc rejects repeated fields inside a oneof: securityservices.proto:249:5: Fields in oneofs must not have labels (required / optional / repeated). Move the model list into a nested ImageIdentifier.HardwareModelList message and use it as the oneof member.
henrymitchellhibbert-lab
force-pushed
the
main
branch
from
October 6, 2026 02:36
a315cf4 to
440c2a6
Compare
Runs protoc on every proto under proto/ for pushes and pull requests to main, so changes that break compilation are caught before merge.
henrymitchellhibbert-lab
force-pushed
the
main
branch
from
October 6, 2026 02:58
440c2a6 to
284c2d8
Compare
Contributor
Author
|
CI check is working on my fork https://github.com/henrymitchellhibbert-lab/security-services/actions/runs/37406769205 |
henrymitchellhibbert-lab
marked this pull request as ready for review
October 6, 2026 03:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current file fails to compile:
securityservices.proto:249:5: Fields in oneofs must not have labels (required / optional / repeated).This PR fixes this by wrapping the repeated field in a new message type, and adds a Github Action to catch this category of issue in future.