Add label attribute for ACL entry - #2320
Closed
shri-khare wants to merge 1 commit into
Closed
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Summary: This is similar to opencomputeproject#1158, opencomputeproject#1407, $1430. Those PRs added label attribute for LAG/virtual router, counter, ACL Counter. This PR adds similar label attribute for ACL entries. ACL entries have PRIORITY attribute, but since multiple ACL entries can be configured with same priority, PRIORITY attribute cannot be used to uniquely identlfy an ACL entry within a given ACL Table. Adding a label attribute that can be used to uniquely identify ACL entry object during warmboot. This attribute is consider as user data attached to the object. Signed-off-by: Shrikrishna (Shri) Khare <skhare@meta.com> Signed-off-by: Jasmeet Bagga <jasmeetbagga@meta.com> Signed-off-by: Ron He <zecheng@meta.com>
shri-khare
force-pushed
the
acl-entry-label
branch
from
July 22, 2026 00:02
0280abd to
657fdf4
Compare
Contributor
Author
|
Discarding in favor of #2322 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is similar to #1158, #1407, $1430.
Those PRs added label attribute for LAG/virtual router, counter, ACL Counter. This PR adds similar label attribute for ACL entries.
ACL entries have PRIORITY attribute, but since multiple ACL entries can be configured with same priority, PRIRORITY attribute cannot be used to uniquely identlfy an ACL entry within a given ACL Table.
Adding a label attribute that can be used to uniquely identify ACL entry object during warmboot. This attribute is consider as user data attached to the object.