Repository navigation
docs: guide agents through Windows PR preparation - #1820
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 72dea55a-1aac-467f-b300-bdd51eae9e15
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesAdds a six-step Windows PR preparation skill and links it from the repository’s agent guidance. Example: An agent prepares a prose-only PR at commit 1ddaedf.
Review scores
ProductKind: Docs · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review This PR adds useful, scoped preparation guidance that is absent from current main. No actionable defects were found, and the collaborator-authored item remains open under the maintainer guard. Priority: P3 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherRepository agent instructions route contributors into this skill, which combines the selected change, existing validation guidance, evidence, and PR template into a local draft and readiness handoff. flowchart TD
A[Agent task routing] --> B[PR preparation skill]
B --> C[Validation and proof owners]
B --> D[Scoped review guidance]
C --> E[Current PR template]
D --> E
E --> F[Local draft and readiness handoff]
Technical reviewBest possible solution: Land the focused preparation skill while retaining the existing validation, proof, review, and template owners. Do we have a high-confidence way to reproduce the issue? No runtime bug is claimed; source inspection confirms that current main lacks the proposed consolidated preparation workflow. Is this the best way to solve the issue? The six-step guide addresses the discoverability gap through existing owners and avoids adding runners, duplicated review implementations, or publication authority. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 2dfb4c78ef05. Provenance checked
SecurityNone. EvidenceWhat I checked:
Likely related people:
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 21, 2026, 11:43 PM ET / October 22, 2026, 03:43 UTC. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 72dea55a-1aac-467f-b300-bdd51eae9e15
Publication now defers to the verified repository, base and head and the host's supported tools instead of restating a fork rule with an exception the root instructions do not define. Co-authored-by: bkudiess <7658216+bkudiess@users.noreply.github.com>
What Problem This Solves
Agents need one discoverable workflow for preparing a truthful Windows PR draft without mistaking stale evidence or implementation permission for publication readiness.
User Impact
No product behavior changes. Contributors get a consistent local preparation path that keeps evidence limits and publication authority explicit.
Why This Change Was Made
Adds one skill with six steps: establish the claim and authority, select validation, inspect actual results, review the intended scope, fill the current template, and report readiness before stopping. A root
AGENTS.mdrow, a related-guidance link and a task decision checklist row indocs/AGENT_WORKFLOWS.mdmake it discoverable. The proof skill's PR proof package still owns evidence requirements and now links to this skill for assembling them. Step 4 accounts for both source review and the required independent rubber-duck review; a missing required review is reported as blocked. Existing validation, proof and review guidance remains authoritative; no runner, renderer or CI change.Evidence
Post-commit documentation and skill checks pass. Static walkthroughs cover the completed prose and nonvisual C# authoring pilots plus stale/blocked evidence. One independent Copilot
code-reviewtask covered P0-P3, all three files, 13 links/anchors and the template contract with no actionable findings or optional suggestions. Its reviewed precommit bytes match the first commit,1ddaedf5; the review was not rerun or restamped. Later commits address a follow-up review:82cd10cfadds the rubber-duck gate, the proof-skill back-link and the checklist row, clarifies wording and removes unsupported statements; maintainer commit6cb0b601removes the personal-fork sentence from step 6. Neither later commit was covered by that Copilot review. Model identity is unverified. This is narrative/static review, not shared-helper isolation, dual-model review or end-to-end agent qualification.Change Type
Scope
winnodeRequired proof pools
none: prose-only skill and routing links; no capacity-dependent native behavior changed.Validation
Current head
6cb0b601041ff29e38557c049abb4065cd783114, hosted CI (fast-validation on merge114d8286withmainat1b4d325e):./scripts/validate-docs.ps1./scripts/validate-agent-skills.ps1The local commands below ran only at the first commit and were not rerun locally on
82cd10cfor6cb0b601.git diff --checkpassed locally on the6cb0b601change.At
1ddaedf5eff3b3e3aa57b814bd0b7423e9526384:.\scripts\validate-docs.ps1.\scripts\validate-agent-skills.ps1git diff --check HEAD^ HEADgit diff --checkOn the identical reviewed precommit content,
.\scripts\test-agent-skills-validator.ps1passed 27 fixtures plus repository skills (exit 0, conversation-output evidence). Source correspondence is verified, not a claim of a new fixture run. Full build, Shared/Tray and native runtime proof were not run for this prose-only change.Real Behavior Proof
6cb0b601041ff29e38557c049abb4065cd783114in hosted CI; local commands at1ddaedf5eff3b3e3aa57b814bd0b7423e9526384only.Agent skill validation passed: 12 skills and 21 Markdown files checked.(CI, current head)Yes/No/N/A) N/A, no external artifacts.Security Impact
Yes/No) NoYes/No) NoYes/No) NoYes/No) NoYes/No) NoYes, explain the risk and mitigation: N/ACompatibility and Migration
Yes/No) YesYes/No) NoYes/No) NoReview Conversations
N/A at preparation: no bot review conversations were addressed.