Repository navigation
Enforce platform transaction handle lifetimes - #128
Merged
freeqaz-openai merged 1 commit intoSep 14, 2026
Merged
freeqaz-openai merged 1 commit into
freeqaz-openai merged 1 commit into
Conversation
This was referenced Sep 11, 2026
freeqaz-openai
marked this pull request as ready for review
September 11, 2026 23:03
freeqaz-openai
changed the base branch from
codex/work-76bbb439909015765f9a4886
to
main
September 13, 2026 00:04
freeqaz-openai
force-pushed
the
codex/work-8ac03db200ba1d850e6a5f56
branch
from
September 13, 2026 00:06
d07d6c4 to
f6b0c22
Compare
kevinslin
previously approved these changes
Sep 13, 2026
kevinslin
reviewed
Sep 14, 2026
kevinslin
left a comment
Collaborator
There was a problem hiding this comment.
code looks fine but can we not use export maps? this isn't necessary and bloats the package manifest
freeqaz-openai
force-pushed
the
codex/work-8ac03db200ba1d850e6a5f56
branch
from
September 14, 2026 07:49
f6b0c22 to
cb22ec7
Compare
freeqaz-openai
force-pushed
the
codex/work-8ac03db200ba1d850e6a5f56
branch
from
September 14, 2026 11:27
cb22ec7 to
977fd31
Compare
freeqaz-openai
changed the base branch from
main
to
codex/work-4f093aba450a3d088a059fa7
September 14, 2026 11:27
This was referenced Sep 14, 2026
freeqaz-openai
force-pushed
the
codex/work-4f093aba450a3d088a059fa7
branch
from
September 14, 2026 18:15
43a15c0 to
2e2084a
Compare
freeqaz-openai
force-pushed
the
codex/work-8ac03db200ba1d850e6a5f56
branch
from
September 14, 2026 18:15
977fd31 to
5f87ba8
Compare
freeqaz-openai
merged commit Sep 14, 2026
a2dc7ec
into
codex/work-4f093aba450a3d088a059fa7
13 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repository handles retained after a platform transaction callback can mutate a published memory snapshot or query a released PostgreSQL client. Bind the existing stores' outward repositories to the callback lifetime: reject new calls after the callback settles and drain accepted complete operations before commit, rollback, or release. Read callbacks receive frozen projections containing only read methods, and worker queue/query access follows the same boundary.
Keep the existing inline resource implementations, interface ownership, and root package entrypoint. The reduced scope removes the resource extraction, generic factory API, error relocation, and fourteen subpath exports from the earlier version. Resource, audit, and work atomicity remain intact.
Dependency
This change follows #137's transaction-outcome fix. It adds lifetime enforcement to the same PostgreSQL owner while retaining every COMMIT, transport-error, and cleanup outcome branch. The combined production and test sources match the previously reviewed combination; the reordered stack makes each fix independently reviewable. There is no dependency on #129.
Validation
The conflict resolution preserves the previously reviewed combined transaction owner exactly. The only complete-tree difference from that combination moves the existing outcome paragraph into the PostgreSQL guide.
Local SQL validation used PostgreSQL 16.15, fresh migrated private databases, and restricted application credentials; the owned server stopped afterward. CI's PostgreSQL 18.6 needs its own run on the updated head. These checks establish persistence and the selected controller/worker workflows, without claiming live runtime or GitHub token execution.