Skip to content

chore(autoreview): use the shared canonical skill - #17

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/shared-autoreview-20261002
Oct 6, 2026
Merged

vincentkoc merged 1 commit into
mainfrom
refactor/shared-autoreview-20261002

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

Repository-local autoreview copies drift and can retain retired prerequisites such as TruffleHog.

User Impact

Install autoreview once from openclaw/agent-skills using the setup linked in .agents/skills/autoreview/SKILL.md. Reviews run from this repository through that shared installation. Updating its source checkout updates all symlinked consumers; copy-mode users reinstall once. Product runtime behavior is unchanged.

Why This Change Was Made

Keep only the canonical Markdown entrypoint and remove the copied helper, fixtures, and implementation tests.

Canonical owner and preserved downstream fixes: openclaw/agent-skills#305. Shared changes belong upstream; review runs do not download or update code automatically.

Evidence

  • All 17 consumer entrypoints match the canonical template; each contains no local helper or implementation tests.
  • git diff --check passes; independent integration review checked callers and removed gates.
  • The shared installer and helper dry runs pass from consumer repositories without TruffleHog. Canonical regression tests and review are recorded in the upstream PR.
  • Product runtime suites were not run for this shared-tooling cutover.

@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Oct 2, 2026
@clawsweeper

clawsweeper Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codex review: needs maintainer review before merge. Reviewed October 6, 2026, 2:46 PM ET / 18:46 UTC (Revision 8).

ClawSweeper review

What this changes

Replace the copied autoreview helper and tests with shared-installation instructions, updating contributor guidance and the changelog.

Merge readiness

✅ Ready for maintainer review

This cutover remains useful and is not implemented on the pinned main branch. The previous draft blocker is resolved, and inspection found no concrete merge-blocking defect.

Priority: P3
Reviewed head: e0d5fa6edbdb0aed3f2c87eaa7ebcc74ae223488

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) A focused consolidation with consistent caller guidance and no concrete blocking finding.
Proof confidence 🌊 off-meta tidepool Not applicable: The MEMBER-authored tooling cutover is exempt from ordinary contributor proof. Canonical source supports installation and caller-directory selection; no persisted product-data contract changes.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Verification

Check Result Evidence
Real behavior Not applicable Not applicable: The MEMBER-authored tooling cutover is exempt from ordinary contributor proof. Canonical source supports installation and caller-directory selection; no persisted product-data contract changes.
Evidence reviewed 7 items Pinned cutover: The introduced changes remove the copied implementation, retain a Markdown entrypoint, document installation, and add an Unreleased entry. Main still contains the copied helper.
Caller and package boundary: Remaining autoreview references use the shared entrypoint or installed helper. Package scripts contain no dependency on the deleted harness, and published package files exclude the skill directory.
Affirmative dependency and existing installer: The target entrypoint explicitly requires this canonical repository. Its current main already provides scripts/install-skills with the documented ~/.agents/skills default and symlink/copy modes; the shared helper discovers the reviewed repository from the caller's working directory.
Findings None None.
Security None None.

How this fits together

Autoreview is contributor tooling that reads repository changes and produces review findings. This cutover moves its implementation to an operator-installed shared skill while retaining repository-specific guidance.

flowchart LR
  A[Repository changes] --> B[Local review guidance]
  B --> C[Shared skill installation]
  C --> D[Canonical review helper]
  D --> E[Review findings]
Loading

Before merge

None.

Agent review details

Security

None.

Review metrics

Metric Value Why it matters
Copied tooling removed 20 files affected; +20 / -17,226 lines The large deletion retires duplicated contributor tooling without changing the exporter runtime.

Technical review

Best possible solution:

Keep repository-specific review policy local and use the documented canonical installation as the single helper and test owner.

Do we have a high-confidence way to reproduce the issue?

Not applicable: this is a tooling consolidation, with no reported runtime bug to reproduce.

Is this the best way to solve the issue?

Yes: the existing canonical installer supports the documented path, and repository callers no longer depend on the removed copy.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 51ee7d47997f.

Labels

Label changes:

No label changes.

Label justifications:

  • P3: This is contributor-tooling consolidation with no identified product-runtime change.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The MEMBER-authored tooling cutover is exempt from ordinary contributor proof. Canonical source supports installation and caller-directory selection; no persisted product-data contract changes.

Evidence

What I checked:

  • Pinned cutover: The introduced changes remove the copied implementation, retain a Markdown entrypoint, document installation, and add an Unreleased entry. Main still contains the copied helper. (.agents/skills/autoreview/SKILL.md:8, e0d5fa6edbdb)
  • Caller and package boundary: Remaining autoreview references use the shared entrypoint or installed helper. Package scripts contain no dependency on the deleted harness, and published package files exclude the skill directory. (CONTRIBUTING.md:45, e0d5fa6edbdb)
  • Affirmative dependency and existing installer: The target entrypoint explicitly requires this canonical repository. Its current main already provides scripts/install-skills with the documented ~/.agents/skills default and symlink/copy modes; the shared helper discovers the reviewed repository from the caller's working directory. (scripts/install-skills:20, 3d3034af58d4)
  • Canonical rollout context: fix(autoreview): share one installation across repositories agent-skills#305 remains open. Its body records consumer dry runs and fresh/forced-upgrade installations in symlink and copy modes. The install mechanism needed by this target already exists on canonical main. (4106a8fdcd46)
  • Re-review continuity: The previous completed review had no findings or published rank-up moves and requested leaving draft. Live metadata confirms the same pinned head is now a non-draft, open, unmerged MEMBER-authored PR. (e0d5fa6edbdb)
  • Prior area history: Main-branch path history identifies Vincent Koc's earlier repository-baseline and contributor-guidance work, supporting routing independently of this proposed branch. Detailed local blame/show inspection encountered HTTP 403 while retrieving missing historical objects; no source-line introduction attribution is claimed. (CONTRIBUTING.md, 431983da4c69)

Likely related people:

  • vincentkoc: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)

Rating scale

Score Internal tier Crab rank Meaning
6/6 S 🦀 challenger crab Exceptional readiness
5/6 A 🦞 diamond lobster Very strong readiness
4/6 B 🐚 platinum hermit Good normal PR; ordinary maintainer review
3/6 C 🦐 gold shrimp Useful, but confidence is limited
2/6 D 🦪 silver shellfish Proof or implementation needs work
1/6 F 🧂 unranked krab Not merge-ready
N/A NA 🌊 off-meta tidepool Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

History

Review history (7 earlier review cycles)
  • reviewed 2026-10-02T09:49:29.749Z sha e0d5fa6 :: needs maintainer review before merge. :: none
  • reviewed 2026-10-02T21:45:36.122Z sha e0d5fa6 :: needs maintainer review before merge. :: none
  • reviewed 2026-10-03T02:44:27.715Z sha e0d5fa6 :: needs changes before merge. :: none
  • reviewed 2026-10-03T11:09:41.261Z sha e0d5fa6 :: needs changes before merge. :: none
  • reviewed 2026-10-04T03:11:40.105Z sha e0d5fa6 :: needs changes before merge. :: none
  • reviewed 2026-10-05T05:58:10.963Z sha e0d5fa6 :: needs changes before merge. :: none
  • reviewed 2026-10-06T17:45:41.408Z sha e0d5fa6 :: needs changes before merge. :: none

@vincentkoc
vincentkoc marked this pull request as ready for review October 6, 2026 18:44
@vincentkoc
vincentkoc requested a review from a team as a code owner October 6, 2026 18:44
@clawsweeper

clawsweeper Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@vincentkoc
vincentkoc merged commit b695364 into main Oct 6, 2026
7 checks passed
@vincentkoc
vincentkoc deleted the refactor/shared-autoreview-20261002 branch October 6, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant