Repository navigation
build(deps): refresh terminal build and lint tooling - #118
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex review: needs maintainer review before merge. What this changesThis PR updates tsdown to 0.23.2 and oxlint-tsgolint to 7.0.2005, refreshes their transitive dependencies, and adds a changelog entry. Example: A contributor installs dependencies and runs pnpm check.
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep this PR open: it provides focused, maintainer-directed tooling maintenance absent from main, with no actionable defect found. Priority: P3 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherDevelopment tooling consumes TypeScript sources to produce published JavaScript, declarations, and lint diagnostics; Ghostty remains the unchanged runtime dependency. flowchart LR
A[TypeScript sources] --> B[tsdown and Rolldown]
B --> C[JavaScript and declarations]
C --> D[Package consumers]
A --> E[Oxlint and tsgolint]
E --> F[Contributor diagnostics]
Technical reviewBest possible solution: Land the focused tooling refresh once the existing CI matrix completes successfully. Do we have a high-confidence way to reproduce the issue? This is dependency maintenance rather than a reported product failure; the manifest and lockfile establish the version changes directly. Is this the best way to solve the issue? Updating the existing tooling in place is appropriately scoped, and upstream metadata supports the transitive selections without changing runtime contracts. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 5b70a1421a0c. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 26, 2026, 7:35 AM ET / 11:35 UTC. |
Refresh tsdown to 0.23.2 and oxlint-tsgolint to 7.0.2005, together with compatible transitive build dependencies. The updates satisfy the existing two-day cooldown and retain the supported Node.js versions and pinned Ghostty runtime.
Validation: pnpm install --frozen-lockfile passed supply-chain policy checks; pnpm check passed (140 tests, build, portable type checks, lint, formatting, package checks); independent autoreview completed with no actionable P0–P3 findings. Validation ran locally at low priority after no Crabbox lease was granted. CI covers Linux, macOS, Windows, browser smoke, and coverage. No package version change or publication.