Skip to content

build(deps): refresh terminal build and lint tooling - #118

Merged
steipete merged 1 commit into
mainfrom
maintenance/s21-libterminal-deps
Oct 26, 2026
Merged

steipete merged 1 commit into
mainfrom
maintenance/s21-libterminal-deps

Conversation

@steipete

Copy link
Copy Markdown
Contributor

Refresh tsdown to 0.23.2 and oxlint-tsgolint to 7.0.2005, together with compatible transitive build dependencies. The updates satisfy the existing two-day cooldown and retain the supported Node.js versions and pinned Ghostty runtime.

Validation: pnpm install --frozen-lockfile passed supply-chain policy checks; pnpm check passed (140 tests, build, portable type checks, lint, formatting, package checks); independent autoreview completed with no actionable P0–P3 findings. Validation ran locally at low priority after no Crabbox lease was granted. CI covers Linux, macOS, Windows, browser smoke, and coverage. No package version change or publication.

@steipete
steipete requested a review from a team as a code owner October 26, 2026 11:22
@clawsweeper

clawsweeper Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T11:23:46.740537Z 7d34b51 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@clawsweeper clawsweeper Bot added P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Oct 26, 2026
@clawsweeper

clawsweeper Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge.

What this changes

This PR updates tsdown to 0.23.2 and oxlint-tsgolint to 7.0.2005, refreshes their transitive dependencies, and adds a changelog entry.

Example: A contributor installs dependencies and runs pnpm check.

  • Before: Builds use tsdown 0.23.1 and type-aware linting uses oxlint-tsgolint 7.0.2004.
  • After: Builds use tsdown 0.23.2 and type-aware linting uses oxlint-tsgolint 7.0.2005.

Review scores

Measure Result What it means
Overall readiness 🦐 gold shrimp (3/6) Focused and apparently correct maintenance, supported by source inspection, upstream metadata, and partial CI completion; behavioral evidence remains limited to reported validation and automated checks.
Proof confidence 🦐 gold shrimp (3/6) Maintainer-authored tooling maintenance is outside the ordinary contributor proof gate; reviewed evidence consists of the author's validation report and exact-head CI, without a separate application demonstration.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
User problem: Contributors build and lint with older eligible tooling releases.
Reason: The supplied maintainer-authored classification establishes direction, and the focused refresh follows existing tooling policy without introducing a new product contract.

Merge readiness

✅ Ready for maintainer review

Keep this PR open: it provides focused, maintainer-directed tooling maintenance absent from main, with no actionable defect found.

Priority: P3
Reviewed head: 7d34b5106a2ea96fe09eca02d1ff8bef9667179d

Before merge

None.

Findings

None.

Agent review details

How this fits together

Development tooling consumes TypeScript sources to produce published JavaScript, declarations, and lint diagnostics; Ghostty remains the unchanged runtime dependency.

flowchart LR
  A[TypeScript sources] --> B[tsdown and Rolldown]
  B --> C[JavaScript and declarations]
  C --> D[Package consumers]
  A --> E[Oxlint and tsgolint]
  E --> F[Contributor diagnostics]
Loading

Technical review

Best possible solution:

Land the focused tooling refresh once the existing CI matrix completes successfully.

Do we have a high-confidence way to reproduce the issue?

This is dependency maintenance rather than a reported product failure; the manifest and lockfile establish the version changes directly.

Is this the best way to solve the issue?

Updating the existing tooling in place is appropriately scoped, and upstream metadata supports the transitive selections without changing runtime contracts.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 5b70a1421a0c.

Provenance checked

  • Direct build and lint dependency versions keeps the original intent (72452c7: Refresh tested development dependencies while preserving supported Node versions and the two-day cooldown.)
  • Transitive build and test dependency resolutions keeps the original intent (chore(deps): refresh transitive build and test tooling #73: Refresh compatible transitive tooling and consolidate shared Rolldown resolutions without changing runtime dependencies.)

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

  • Verified introduced changes: The pinned diff changes only two development dependency ranges, their lockfile resolutions, and one Unreleased changelog entry; main retains the earlier versions. (package.json:99, 7d34b5106a2e)
  • Repository policy and compatibility: The complete root AGENTS.md applies to all changed paths; no nested policy, maintainer notes, or pr-simplify skill was present. The patch preserves pnpm 11.28.4, the 2880-minute cooldown, supported Node ranges, exports, and Ghostty 0.4.0. No helper, installation, build, or test was run during this review. (AGENTS.md:1, 7d34b5106a2e)
  • Tooling provenance: build(deps): refresh tooling and patch source-map-js #108 established the previous direct versions while retaining the cooldown and Node floors; chore(deps): refresh transitive build and test tooling #73 documents deliberate transitive tooling refreshes. This PR preserves those constraints and the patched Vite/source-map-js selections. (package.json:99, 72452c77728f)
  • Upstream dependency contract: The published tsdown 0.23.2 manifest explicitly requires rolldown ~1.2.15 and rolldown-plugin-dts ^0.29.0-beta.2, matching the lockfile. Its Node range matches the documented development toolchain. Release: https://github.com/rolldown/tsdown/releases/tag/v0.23.2; manifest: https://registry.npmjs.org/tsdown/0.23.2.
  • Exact-head validation and discussion: The full body and comments contain the author's frozen-install and pnpm-check validation report and no additional behavioral artifacts. Exact-head Linux and Windows checks passed; browser smoke remained in progress and both macOS checks queued, with no failed check reported. (.github/workflows/ci.yml, 7d34b5106a2e)

Likely related people:

  • Peter Steinberger: Raw commit 19206c9 adds package.json:84 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 19206c9629c5; files: package.json)
  • Vincent Koc: Raw commit 402f019 adds package.json:73 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 402f019f2b17; files: package.json)

Labels

Label changes:

  • add P3: Routine development-tool maintenance with no demonstrated runtime regression or urgent user impact.
  • add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P3: Routine development-tool maintenance with no demonstrated runtime regression or urgent user impact.
  • rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 26, 2026, 7:35 AM ET / 11:35 UTC.

@steipete
steipete merged commit 7a94649 into main Oct 26, 2026
16 checks passed
@steipete
steipete deleted the maintenance/s21-libterminal-deps branch October 26, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant