Repository navigation
ci: move macOS release preflight to Xcode 27 - #165
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex review: needs maintainer review before merge. What this changesThis PR moves macOS release preflight to xcode-27, explicitly sets the macOS 13 deployment target, and checks execution of both architectures. Example: A release preflight builds crawlctl for darwin/amd64 and darwin/arm64.
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep this PR open: the maintainer-directed release migration is absent from main, and the pinned diff introduces no actionable correctness or security defect. Priority: P3 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherThe repository’s release caller validates dispatch inputs and macOS binaries before handing tagging, signing, notarization, verification, and publication to the shared release workflow. flowchart TD
A[Release dispatch] --> B[Version validation]
B --> C[Xcode 27 preflight]
C --> D[Deployment and execution checks]
D --> E[Notarization access check]
E --> F[Shared release workflow]
F --> G[Verified release artifacts]
Technical reviewBest possible solution: Retain this focused migration while preserving the existing deployment, credential, and shared publication boundaries. Do we have a high-confidence way to reproduce the issue? This PR changes release infrastructure rather than reporting a reproduced product defect. Is this the best way to solve the issue? The change uses the existing preflight owner and matches the shared workflow’s Xcode 27 and Rosetta approach without adding a competing release path. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 97b4d5b647e4. Provenance checked
TestingProof path: unit tests only. SecurityNone. EvidenceWhat I checked:
LabelsLabel changes:
Label justifications:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 18, 2026, 10:54 PM ET / October 19, 2026, 02:54 UTC. |
Move repo-local macOS release preflight from macos-14 to xcode-27. Preserve the macOS 13 minos gate, make the deployment target explicit for preflight and GoReleaser, and execute the amd64 helper under asserted/installed Rosetta. No Intel hardware is required.
The shared release-go-cli workflow remains on openclaw/release-workflows@v1 and is maintained centrally. Go 1.27.2 and the documented go 1.27.0 minimum are unchanged.
Validation: 41 release/workflow tests, actionlint and independent review through P3 passed. The full documented
make checkgate passed on an isolated Linux worker with Go 1.27.2, including module tidiness, vet, deadcode, govulncheck, unit tests, race tests and release contracts. Govulncheck found zero reachable or imported-package vulnerabilities; one module-only advisory is outside the used code. Exact-head and merged-main CI plus a merged-main release dry_run are required before closeout. No release, tag or product version bump is included.