Repository navigation
build: repair Crabbox hydration and refresh pprof - #164
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
steipete
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Crabbox waits indefinitely for Crawlkit's hydration readiness marker and misses its shutdown signal because the workflow uses job-scoped filenames while the CLI expects lease-scoped filenames.
User Impact
Maintainers can prepare and stop the CI test environment using the current Crabbox CLI. No public API or runtime behavior change. The Go 1.27.0 minimum, Go 1.27.2 toolchain, SQLite version, and required libc version remain unchanged.
Why This Change Was Made
Use
<lease>.env,<lease>.env.sh, and<lease>.stop; retain the job name inside the readiness metadata. Omit the explicit Go cache input rejected by the local Actions adapter; upstream setup-go retains its normal default caching on GitHub. Regression tests execute the actual workflow shell steps in a temporary home. Also refresh SQLite's indirect pprof test dependency to its October 16 revision and update the checksums.Evidence
Both new regressions fail against the original workflow: readiness cannot find its marker and shutdown ignores the stop file. All 41 script tests pass after the repair.
go mod tidyis clean,go mod verifypassed, and independent Codex autoreview is clean at P0–P3. The defaultcrabbox warmup→crabbox run --shell -- 'make check'path passed on a fresh lease at607f09d7aabc145c12093e419a4410e70cae9fdb, including automatic local hydration, vet, dead-code analysis, vulnerability scanning, unit tests, race tests, and all 41 script tests. An earlier live GitHub-runner retry also verified readiness and shutdown.govulncheckreports no affected symbols or imported packages; its module-only OpenPGP advisory concerns an unused package with no fixed version. Hydration proof.