Repository navigation
fix(ci): avoid duplicate main-push CodeQL scans - #254
Merged
Merged
Conversation
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. |
vincentkoc
marked this pull request as ready for review
November 3, 2026 12:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Main-push CodeQL repeats scans in a quiet repository, while attribute-only PRs can change checked-out source without triggering analysis.
User Impact
Full weekly Monday 07:23 UTC analysis and PR/manual profile scans remain available. Normal CI, package behavior, deployment, and release workflows are unchanged.
Why This Change Was Made
Remove only the main-push scan, admit root/nested checkout attributes on PRs, and separate scheduled/manual concurrency from superseded PR runs. Both custom query profiles, all action pins, job names, permissions and manual profile choices are preserved. The root policy note records the cadence.
Evidence
git diff --checkpassed.Final proof on
1787bcdc9f8ce69f2f47198631cfe7871c9996b9: CI passed typecheck, lint, format, coverage, package smoke, Windows execution, and Node 22/24 runtime checks; both CodeQL profiles passed. The first head exposed a test-only strict-index typing error; the one-line repair was independently reviewed and passes on this head. The unrelated ClawSweeper intake dispatch failed with Worker HTTP 500; it is not a required check, and no bypass or successful hosted bot review is claimed.