Repository navigation
improve(ci): avoid duplicate package builds - #252
Merged
Merged
Conversation
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
CI compiles the same clean package twice immediately before verifying its installed artifact.
User Impact
No application behavior changes. CI avoids redundant compilation while retaining clean package emission and installed-package smoke coverage on Node 22, 24 and 26.
Why This Change Was Made
The existing smoke helper runs real
npm pack, whose unchangedprepackscript runspnpm run buildand cleans/recompilesdist. Remove only the preceding identicalpnpm buildcommands from two workflow declarations, covering three Linux jobs. Keep native typecheck, lint, format, test/coverage, Windows, security, packaging, permissions and concurrency unchanged. No new dependency, runtime pin, cache or local command policy.Evidence
79c1495f20d33b68ca4439dfa9dfef18ed7a460e; product head:f3505124159b5bfbb5ad6605f95e1e400b3cb441.ec83d0c3e55b46bcd7a54ce4a63ed3dbac634d1fa3d7cbf595b30c32b0ff6f43. Both pipelines reject invalid TypeScript and failing prepack hooks. No skip/stub replaces the installed CLI assertions.