Repository navigation
fix: adopt PCM-compatible scanner inspection - #4117
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Codex review: needs maintainer review before merge. What this changesThis PR adopts the merged Markdown and PCM scanner repairs while retaining historical source-to-lock bindings. Example: PixelLab 3.0.0 contains 126 text files, a PCM WAV asset, and missing-reference caveats.
Review scores
ProductKind: Bug fix · Worth it: Yes · Fix scope: Partial Merge readiness✅ Ready for maintainer review Keep open: this collaborator-authored PR addresses scanner inspection failures that remain on main, and no introduced blocking defect was identified. Priority: P2 Before mergeNone. FindingsNone. Tests
Agent review detailsHow this fits togetherClawHub's worker installers build the pinned ClawScan source and matching scanner adapters, which turn uploaded artifact bytes into findings and completeness evidence consumed by the existing judge and publication checks. flowchart TD
A[Source pin and lock binding] --> B[Verified scanner installation]
C[Original upload bytes] --> D[SkillSpector inspection]
B --> D
D --> E[ClawScan evidence validation]
E --> F[Existing judge]
F --> G[Publication checks]
Technical reviewBest possible solution: Adopt the upstream repairs through the existing source pin and lock matrix, then recover the original upload separately through authorized publication checks. Do we have a high-confidence way to reproduce the issue? Shilo supplies a Markdown-plus-WAV reproduction, and the selected upstream diff exposes the previous WAV rejection and prose-ownership paths; this review executed no target code. Is this the best way to solve the issue? Best-fix verdict: best; upstream owns scanner interpretation, so adopting its matched producer/consumer repair is preferable to duplicating WAV handling in ClawHub or weakening the worker's completion checks. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 793dea96f266. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
Review metrics
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 28, 2026, 8:03 AM ET / 12:03 UTC. |
4ce1933 to
a27156f
Compare
|
Production activation and original-upload recovery are verified. Merged backend PixelLab 3.0.0 recovery proof: all 127 original files / 1,101,503 bytes match storage, public metadata/download and installed payloads. Before activation, both anonymous CLI versions could not install this retained version; afterward:
Exactly one audited CAS retry followed completion of older-source workers. The automatically dispatched normal worker confirms the exact attempt, built cafdd8a revision, one fresh scan, one judge invocation and zero judge operational failures; both checks passed and normal finalization published the original. Creator/provenance fields and all original bytes remain unchanged; the audit retains the prior failure count 3/checks. The benign verdict retains its notes/guidance. No second retry or manual worker dispatch occurred. This completes this adoption's PixelLab recovery. Issue #4046 remains open for the other reported cases and pending-version behavior. |
Summary
PixelLab's unchanged Markdown/WAV upload cannot complete the selected scanner. Adopt the reviewed scanner repairs through the existing source pin and source-bound dependency matrix.
Canonical Markdown prose ownership preserves shell continuations. Strict original-byte PCM validation allows the explicit WAV binary exclusion alongside missing-reference caveats. Scanner budgets, model controls, findings and publication authorization remain intact.
Source repairs: ClawScan #124 and #125. Related: #4046.
Evidence
After: All 127 original files / 1,101,503 bytes match. Full model-enabled inspection completes all 126 text files in 108.92 seconds within the unchanged 600-second budget, with no degraded analyzers or limits. The actual Go adapter accepts the full report operationally while preserving all 68 findings, three missing-reference caveats and raw report bytes. The WAV remains explicitly binary-excluded. Production verdict and original-publication recovery follow separately.
sha256:b5483763c5bad524cd98e8b33ca0d06b26450bd601b8be02af5bef4edad36cdd.793dea96f26627f234ee1f305aca7d2581f91368, above prerequisite #4116. Both patch deltas remain byte-identical. Fresh integration review ata27156f02eec6737ef0eec7fb6d03fc3528cb135is scoped-clean. Fresh combined-stack validation: static; all 15 focused tests; full unit coverage (8,304 passed / 5 skipped, no unhandled errors); TypeScript/build; package verification — all pass..Merge Danger
Door: two-way
Reversible source pin. Production activation and audited original recovery remain separately verified steps.
Blast Radius: scanner
Existing failure audits, download identities, coverage limits and security findings must remain intact.