Skip to content

fix: adopt PCM-compatible scanner inspection - #4117

Merged
Patrick-Erichsen merged 1 commit into
fix-fixture-http-probesfrom
adopt-pcm-wave-scanner
Oct 28, 2026
Merged

Patrick-Erichsen merged 1 commit into
fix-fixture-http-probesfrom
adopt-pcm-wave-scanner

Conversation

@Patrick-Erichsen

@Patrick-Erichsen Patrick-Erichsen commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

PixelLab's unchanged Markdown/WAV upload cannot complete the selected scanner. Adopt the reviewed scanner repairs through the existing source pin and source-bound dependency matrix.

-aff544dc623c9b2d420bbd13a2c8aab46a90738c
+cafdd8a5766fa82874a805a4af369cfd0a038018

Canonical Markdown prose ownership preserves shell continuations. Strict original-byte PCM validation allows the explicit WAV binary exclusion alongside missing-reference caveats. Scanner budgets, model controls, findings and publication authorization remain intact.

Source repairs: ClawScan #124 and #125. Related: #4046.

Evidence

  • Before: The unchanged PixelLab 3.0.0 original cannot complete Markdown inspection and WAV exclusion accounting.
    After: All 127 original files / 1,101,503 bytes match. Full model-enabled inspection completes all 126 text files in 108.92 seconds within the unchanged 600-second budget, with no degraded analyzers or limits. The actual Go adapter accepts the full report operationally while preserving all 68 findings, three missing-reference caveats and raw report bytes. The WAV remains explicitly binary-excluded. Production verdict and original-publication recovery follow separately.
  • Exact-source CI and native runtime publication pass. Independent registry checks match both native tested configurations and smoke results; immutable index: sha256:b5483763c5bad524cd98e8b33ca0d06b26450bd601b8be02af5bef4edad36cdd.
  • Qualification retains every original inventory, complete static finding/completeness payload, suppression and risk across 30 originals. Passes 109 PCM, 1,279 installed-adapter and 861 source-integration controls; reconstructs 138 source/resource/dependency identities. Source and consumer independent P0–P3 reviews are terminal clean.
  • Rebased once onto accepted main 793dea96f26627f234ee1f305aca7d2581f91368, above prerequisite #4116. Both patch deltas remain byte-identical. Fresh integration review at a27156f02eec6737ef0eec7fb6d03fc3528cb135 is scoped-clean. Fresh combined-stack validation: static; all 15 focused tests; full unit coverage (8,304 passed / 5 skipped, no unhandled errors); TypeScript/build; package verification — all pass..
  • Original upper-head CI failed twice in the local browser inspector-summary path; both receipts remain. The new base includes the accepted inspector error-boundary repair. Fresh CI validates both current heads; no timeout or assertion was weakened.

Merge Danger

Door: two-way

Reversible source pin. Production activation and audited original recovery remain separately verified steps.

Blast Radius: scanner

Existing failure audits, download identities, coverage limits and security findings must remain intact.

@clawsweeper

clawsweeper Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clawhub Ready Ready Preview Oct 28, 2026 12:26pm UTC

Request Review

@clawsweeper clawsweeper Bot added clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-environment Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. P2 Normal backlog priority with limited blast radius. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-environment Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. labels Oct 28, 2026
@clawsweeper

clawsweeper Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge.

What this changes

This PR adopts the merged Markdown and PCM scanner repairs while retaining historical source-to-lock bindings.

Example: PixelLab 3.0.0 contains 126 text files, a PCM WAV asset, and missing-reference caveats.

  • Before: Markdown inspection and WAV exclusion accounting prevent operational completion.
  • After: The selected scanner can recognize composed Markdown prose and validate the WAV exclusion while retaining findings, reference caveats, and separate publication checks.

Review scores

Measure Result What it means
Overall readiness 🦐 gold shrimp (3/6) A focused, correct adoption with confidence strongest at the source and installed-package contract boundaries.
Proof confidence 🦐 gold shrimp (3/6) This collaborator-authored PR is outside the ordinary contributor proof gate; its body reports a model-enabled PixelLab scan and actual Go-adapter acceptance, while directly inspected evidence covers source contracts, installed-package controls, and successful exact-source workflows rather than the claimed original-bundle output.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Bug fix · Worth it: Yes · Fix scope: Partial
User problem: An unchanged upload containing ordinary Markdown and PCM audio cannot finish its required scanner checks.
Reason: The collaborator-authored adoption has owner-approved direction and addresses the demonstrated scanner defect, while correctly using Related for the broader publication-recovery issue.

Merge readiness

✅ Ready for maintainer review

Keep open: this collaborator-authored PR addresses scanner inspection failures that remain on main, and no introduced blocking defect was identified.

Priority: P2
Reviewed head: 4ce193319708db18163d0f413a9ad0108b71ceaa

Before merge

None.

Findings

None.

Tests

  • Missing end-to-end proof: The original-bundle scan and Go-adapter results are reported in prose rather than an inspectable runtime trace; ordinary contributor proof is exempt for this collaborator-authored PR.
Agent review details

How this fits together

ClawHub's worker installers build the pinned ClawScan source and matching scanner adapters, which turn uploaded artifact bytes into findings and completeness evidence consumed by the existing judge and publication checks.

flowchart TD
  A[Source pin and lock binding] --> B[Verified scanner installation]
  C[Original upload bytes] --> D[SkillSpector inspection]
  B --> D
  D --> E[ClawScan evidence validation]
  E --> F[Existing judge]
  F --> G[Publication checks]
Loading

Technical review

Best possible solution:

Adopt the upstream repairs through the existing source pin and lock matrix, then recover the original upload separately through authorized publication checks.

Do we have a high-confidence way to reproduce the issue?

Shilo supplies a Markdown-plus-WAV reproduction, and the selected upstream diff exposes the previous WAV rejection and prose-ownership paths; this review executed no target code.

Is this the best way to solve the issue?

Best-fix verdict: best; upstream owns scanner interpretation, so adopting its matched producer/consumer repair is preferable to duplicating WAV handling in ClawHub or weakening the worker's completion checks.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 793dea96f266.

Provenance checked

  • Immutable scanner source selection keeps the original intent (016fea6: The prior adoption selected reviewed native-validator inspection while leaving production activation and original-upload recovery separate.)
  • Source-bound diagnostic dependency validation keeps the original intent (8c5e1fe: Bind each reviewed source to its exact dependency digest while preserving historical incident runtimes and rejecting cross-source substitutions.)

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

Likely related people:

  • Patrick Erichsen: Raw commit 016fea6 adds scripts/security/clawscan-diagnostic-runtime.ts:23 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 016fea6baa71; files: scripts/security/clawscan-diagnostic-runtime.ts)
  • Josh Avant: Raw commit 6e6c57d adds specs/security-consumer-model-policy.md:42 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: medium; commits: 6e6c57d1b681; files: specs/security-consumer-model-policy.md)

Review metrics

Metric Value Why it matters
Introduced scope +12/-2 across four files The adoption extends existing owners without adding another installation or validation path.

Labels

Label changes:

  • add P2: The repair addresses a demonstrated scanner-completeness failure affecting publication of a specific upload, with broader impact unestablished.
  • add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P2: The repair addresses a demonstrated scanner-completeness failure affecting publication of a specific upload, with broader impact unestablished.
  • rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 28, 2026, 8:03 AM ET / 12:03 UTC.

@Patrick-Erichsen

Patrick-Erichsen commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator Author

Production activation and original-upload recovery are verified.

Merged backend fe70ec469976e76eaf06aac61682d3bc7f2ee971 selects scanner cafdd8a5766fa82874a805a4af369cfd0a038018. Exact-main CI, Test, source-bound benign/malicious controls and backend production pass. Live SHA, external rollout modes, four native publication identities and seven historical download hashes verify. Event dispatch is restored to 1 and both worker workflows are active. Initial browser capacity failures remain in attempt 1; no timeout or assertion changed.

PixelLab 3.0.0 recovery proof: all 127 original files / 1,101,503 bytes match storage, public metadata/download and installed payloads. Before activation, both anonymous CLI versions could not install this retained version; afterward:

  • CLI 0.23.3: exit 0, 127/127 original hashes match, no force flags.
  • CLI 0.24.1: exit 0, 127/127 original hashes match, no force flags.

Exactly one audited CAS retry followed completion of older-source workers. The automatically dispatched normal worker confirms the exact attempt, built cafdd8a revision, one fresh scan, one judge invocation and zero judge operational failures; both checks passed and normal finalization published the original. Creator/provenance fields and all original bytes remain unchanged; the audit retains the prior failure count 3/checks. The benign verdict retains its notes/guidance. No second retry or manual worker dispatch occurred.

This completes this adoption's PixelLab recovery. Issue #4046 remains open for the other reported cases and pending-version behavior.

This branch was successfully deployed

1 active deployment
Preview – clawhub — a27156f0 Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Normal backlog priority with limited blast radius. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant