[steipete]

The public browser smoke gate is red because its mobile layout test hard-codes a third-party skills.sh listing that now returns HTTP 404. This fails unrelated PRs before any layout assertion runs.

Move the existing layout assertions into the local-auth profile/context shard and seed the existing doany-skills/skills/reddit-automation fixture before navigation. The test keeps its desktop/mobile typography, grouping, wrapping, and overflow checks. Its topic-count assertion accounts for the seeded entry’s two original topics. Product UI behavior is unchanged.

Evidence: failing main run, with only this test failing (18 other smoke tests passed); the hard-coded public route independently returned HTTP 404.

Remote proof passed on the configured Blacksmith Testbox backend, lease tbx_01m33nwh6z4rcm0er9wakvcwkd (backend run):

• bun run test:pw:local-auth -- --project=chromium e2e/local-auth/skill-hero-layout.pw.test.ts: real disposable Convex and Chromium, 1 passed.
• bun run ci:playwright-smoke: 18 passed.
• bun run ci:static and bun run ci:unit: passed; 7,170 tests passed, 3 skipped.
• Schema and CLI no-emit TypeScript checks: passed.
• Independent Codex autoreview: scoped-clean through P2.

AI-assisted maintenance fix; the code and runtime proof have been reviewed. No release or production deployment is requested.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
clawhub	Ready	Preview	Sep 22, 2026 5:06am UTC

[clawsweeper]

Codex review: blocked before merge.

What this changes

This PR moves skill hero layout checks from a live public listing to a seeded local fixture in the required profile/context browser shard.

Example: The public skills-101/superpowers/ai-video-generation listing disappears.

• Before: Required public smoke fails before reaching the metadata layout assertions.
• After: The assertions use the controlled doany-skills/skills/reddit-automation fixture on disposable local Convex.

Review scores

Measure	Result	What it means
Overall readiness	🦐 gold shrimp (3/6)	No actionable introduced defect was found, but the implementation is redundant with main and does not merit merging.
Proof confidence	🌊 off-meta tidepool	Not applicable: The supplied maintainer-authored classification exempts this test-infrastructure PR from the ordinary contributor proof gate; reported browser success was not independently verified from the cancelled artifact-free backend run.
Patch quality	🐚 platinum hermit (4/6)	No actionable review findings were identified.

Product

Kind: Bug fix · Worth it: No · Fix scope: Complete
User problem: Unrelated contributions fail required browser CI when a third-party listing disappears before layout assertions run.
Reason: The repair had clear value when proposed, but merging this branch now adds no distinct capability beyond current main.

Merge readiness

⛔ Blocked before merge - 2 items remain

Main already implements the central repair through #3802; the supplied maintainer-author guard reserves retirement of this redundant PR for explicit maintainer judgment.

Priority: P3
Reviewed head: 6e343c3f7f4c9d451e0fcee3b443554043dca825
Owner decision: Required. See Decision needed.

Decision needed

• Question: Should this PR be retired because fix(workers): preserve explicit scanner model settings #3802 already implements its central repair?
• Recommendation: Retire the redundant PR: Keep the implementation already on main and close this PR without merging it.
• Why: The source establishes equivalent coverage on main, but the supplied maintainer-author guard requires explicit maintainer judgment before closure.

Before merge

• Resolve maintainer decision - Resolve the maintainer decision shown above before merge.
• Product: not worth merging - The repair had clear value when proposed, but merging this branch now adds no distinct capability beyond current main.

Findings

None.

Agent review details

How this fits together

The browser CI gates load ClawHub pages backed by public or disposable local Convex data and report layout and runtime failures as required checks.

flowchart LR
  A[PR CI] --> B[Public smoke]
  A --> C[Profile context shard]
  C --> D[Local Convex fixture]
  D --> E[Skill detail page]
  E --> F[Layout assertions]

Loading

Technical review

Best possible solution:

Retain main’s runner-owned fixture initialization and existing required layout coverage, and have a maintainer retire this redundant PR.

Do we have a high-confidence way to reproduce the issue?

The original unstable public-listing dependency is absent from current main, which seeds the controlled fixture and runs the assertions locally; no target code was executed during this read-only review.

Is this the best way to solve the issue?

The fixture move addresses the correct layer, but main already provides it with initialization owned by the runner; replacing the URL with another live listing would preserve the original failure mode.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against 3635eb2fcc3b; fix evidence: commit 9a614dc195af, main fix timestamp 2026-09-24T08:03:39Z.

Provenance checked

• Metadata wrapping regression coverage keeps the original intent (c1c9cfb: Preserve semantic wrapping, typography hierarchy, attached dividers, and geometry-based browser assertions.)
• Local-auth profile/context shard keeps the original intent (eb48c40: Group browser coverage while retaining required checks and reducing runner registrations.)

Testing

Proof path: none.

Security

None.

Evidence

What I checked:

• Verified introduced scope: The pinned diff moves the existing assertions, invokes the existing fixture initializer, adjusts the topic count, and updates CI routing, specs, and changelog; application implementation is unchanged. (e2e/local-auth/skill-hero-layout.pw.test.ts:10, 6e343c3f7f4c)
• Equivalent coverage on current main: Current main runs the same typography, grouping, wrapping, overflow, and runtime-error assertions against the controlled fixture in skill-hero-metadata.pw.test.ts; the affected public-smoke test is absent. (e2e/local-auth/skill-hero-metadata.pw.test.ts:13, 3635eb2fcc3b)
• Fixture owned by the runner: Main initializes the canonical fixture before building the app, and the required profile-context matrix includes the relocated metadata test. (scripts/run-playwright-local-auth.ts:694, 3635eb2fcc3b)
• Merged canonical repair: fix(workers): preserve explicit scanner model settings #3802 explicitly includes the fixture repair and merged it in 9a614dc; its scoped source diff verifies the runner initialization and CI routing. (.github/workflows/ci.yml:194, 9a614dc195af)
• Original regression intent: fix: preserve semantic skill metadata wrapping #3735 introduced geometry-based metadata wrapping coverage, building on fix: keep skill hero metadata intact on mobile #3555; the fixture move preserves that intent. (e2e/public-routes-smoke.pw.test.ts:234, c1c9cfbd04c2)
• Current merge state: GitHub reports mergeable=false and mergeable_state=dirty for the pinned head; this is a conflict, not evidence that the introduced patch deletes later main work. (6e343c3f7f4c)

Likely related people:

• Peter Steinberger: Raw commit 7dce023 adds specs/ci.md:74 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 7dce0235285b; files: specs/ci.md)

Review metrics

Metric	Value	Why it matters
Introduced scope	+186/-163 across 5 files	The browser test accounts for +181/-163, predominantly moved assertions; the remaining five added lines cover CI routing and documentation.

Root-cause cluster

Relationship: superseded
Canonical: #3802
Summary: The merged follow-up replaces the same unstable public listing with the controlled local fixture while preserving required layout coverage.

Members:

• canonical: fix(workers): preserve explicit scanner model settings #3802 - Its merged source owns fixture initialization, the relocated test, CI routing, and removal from public smoke.

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Labels

Label changes:

No label changes.

Label justifications:

• P3: Main already repairs the CI reliability problem; the remaining work is disposition of a redundant branch.
• rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

History

Review history (21 earlier review cycles; latest 8 shown)

• reviewed 2026-10-07T12:49:51.251Z sha 6e343c3 :: blocked before merge. :: none
• reviewed 2026-10-07T17:57:08.314Z sha 6e343c3 :: blocked before merge. :: none
• reviewed 2026-10-08T03:44:51.892Z sha 6e343c3 :: blocked before merge. :: none
• reviewed 2026-10-08T15:38:14.110Z sha 6e343c3 :: blocked before merge. :: none
• reviewed 2026-10-08T21:37:01.097Z sha 6e343c3 :: blocked before merge. :: none
• reviewed 2026-10-09T04:43:20.253Z sha 6e343c3 :: blocked before merge. :: none
• reviewed 2026-10-09T11:34:24.096Z sha 6e343c3 :: blocked before merge. :: none
• reviewed 2026-10-10T15:34:02.497Z sha 6e343c3 :: blocked before merge. :: none

Reviewed October 12, 2026, 9:57 AM ET / 13:57 UTC (Revision 22).

[github-actions]

This pull request has been automatically marked as stale due to inactivity.
Please update it or it will be closed.

[github-actions]

Closing due to inactivity.
If this PR should be revived, reopen it with current context and a fresh validation plan.