Repository navigation
build(deps): bump @agentclientprotocol/sdk from 1.9.0 to 2.0.2 - #912
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [@agentclientprotocol/sdk](https://github.com/agentclientprotocol/typescript-sdk) from 1.9.0 to 2.0.2. - [Release notes](https://github.com/agentclientprotocol/typescript-sdk/releases) - [Changelog](https://github.com/agentclientprotocol/typescript-sdk/blob/main/CHANGELOG.md) - [Commits](agentclientprotocol/typescript-sdk@v1.9.0...v2.0.2) --- updated-dependencies: - dependency-name: "@agentclientprotocol/sdk" dependency-version: 2.0.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: blocked before merge. What this changesThis PR upgrades the runtime ACP SDK dependency from 1.9.0 to 2.0.2. Example: Run pnpm run test with the updated lockfile.
Review scores
ProductKind: Maintenance · Worth it: No Merge readiness⛔ Blocked before merge - 4 items remain This PR needs changes: SDK 2 removes APIs still used by the test fixtures and conformance runner, and moves schema files used by four tests; repository policy does not permit closing this unimplemented update. Priority: P2 Before merge
Findings
Provenance
Tests
Agent review detailsHow this fits togetherThe SDK connects acpx's ACP client to agent processes over JSON-RPC streams and supplies protocol APIs and validators to fixtures and the conformance runner. flowchart LR
CLI[acpx CLI] --> Client[ACP client]
Client --> SDK[ACP SDK]
SDK --> Agent[Agent process]
Fixtures[Test fixtures] --> SDK
Runner[Conformance runner] --> SDK
Technical reviewBest possible solution: Retain SDK 1.x until a coordinated migration updates the existing fixtures, conformance runner, and schema consumers together. Do we have a high-confidence way to reproduce the issue? Exact-head CI annotations demonstrate the missing-export failures on all three supported Node test versions; source and upstream package layout independently establish the schema-path failure, without executing target code. Is this the best way to solve the issue? A dependency-only upgrade is incomplete because its consumers still require removed APIs and file locations, and the recorded maintainer direction already calls for a coordinated migration. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 26849fd33785. TestingProof path: none. SecurityNone. EvidenceWhat I checked:
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 26, 2026, 9:41 AM ET / 13:41 UTC. |
|
Closing this dependency-only major update. SDK 2 removes This needs a coordinated fixtures/conformance/schema migration, as already recorded in #905 (comment). Keeping the supported SDK 1.x line for this maintenance round. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps @agentclientprotocol/sdk from 1.9.0 to 2.0.2.
Release notes
Sourced from @agentclientprotocol/sdk's releases.
Changelog
Sourced from @agentclientprotocol/sdk's changelog.
Commits
f2f218dchore(main): release 2.0.2 (#309)d9db04dfix: isolate request-scoped HTTP POST failures (#307)fd86335fix(http): handle CR line endings in SSE streams (#306)46d6197ci: resolve latest Node LTS patches before using runner cache (#308)2ab6151chore(main): release 2.0.1 (#305)ad220c7fix(http): Isolate session stream conflicts from shared transport (#303)810f46achore(deps): bump markdown-it and vitest for security advisories (#304)c2b1a86chore(main): release 2.0.0 (#302)a37f0ddci: use manifest-driven release configuration (#301)8129b47chore: restore the last published release baseline (#299)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)