Fix: add visit_det_classification to Visitor + Json exporter - #30
Merged
Conversation
The ruby team's PR #26 added det_classification_node (payload builder) but missed the visitor method that actually calls it during traversal. Without visit_det_classification in the Visitor class and visit_det_classifications in visit_database, the exporter's to_json silently skipped all 163 DET classification entities — they were in the Database but never reached the JSON output. This commit adds: - visit_det_classifications(database) to Visitor (iterates database.det_classifications) - visit_det_classification in visit_database dispatch - visit_det_classification in Json exporter (calls det_classification_node) Verified: data-private rake browser:build_from_export[iec-61360-4] now produces 163 DET classification entities with non-null preferred_name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing visitor method caused 163 DET classification entities to be silently dropped from JSON output. Now fixed + verified end-to-end.