Skip to content

Fix CI workflow triggers to match default branch - #17

Merged
benrfairless merged 1 commit into
mainfrom
bugfix/fix-ci-trigger
Aug 13, 2026
Merged

Fix CI workflow triggers to match default branch#17
benrfairless merged 1 commit into
mainfrom
bugfix/fix-ci-trigger

Conversation

@benrfairless

Copy link
Copy Markdown
Member

Description

Fixes the CI workflow triggers in .github/workflows/ci.yml. The workflow was configured to run on pushes and pull requests targeting master, but this repository's default branch is main, so CI never ran. It now runs on pushes to main and on all pull requests (no base-branch filter, so stacked pull requests also get checks). Also points the README CI badge at the main branch so it reflects real status.

Motivation and Context

CI added in #15 has never actually executed because of the branch name mismatch — every PR and push has silently skipped checks. This is the smallest possible fix and is a prerequisite for the follow-up modernisation PRs, which rely on CI feedback.

How Has This Been Tested?

  • Checked affected area manually on my own / staging system
  • Ran automated tests on my own system
  • Confirmed it passed the GitHub actions tests

Workflow-only change: verified by the CI run on this very pull request (previously no runs triggered at all).

Screenshots (if appropriate):

N/A

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Part 1 of a 5-PR modernisation series (merge order: this one first).

Assisted-by: opencode/anthropic.claude-fable-5

The CI workflow only ran on pushes and pull requests targeting
'master', but the repository's default branch is 'main', so the
workflow never ran at all. Trigger on pushes to main and on all pull
requests (so pull requests stacked on other branches still get
checks), and point the README badge at the main branch.

Assisted-by: opencode/anthropic.claude-fable-5
Signed-off-by: Ben Fairless <ben@oaf.org.au>
@benrfairless
benrfairless force-pushed the bugfix/fix-ci-trigger branch from 3a5ffa7 to 25c1c51 Compare August 12, 2026 03:00
@benrfairless
benrfairless requested a review from a team as a code owner August 12, 2026 03:00

@ianheggie-oaf ianheggie-oaf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - LGTM at a glance

@benrfairless
benrfairless merged commit ffa5288 into main Aug 13, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants