Skip to content

Validate arguments in tart set - #1387

Open
reginaldalfret wants to merge 1 commit into
openai:mainfrom
reginaldalfret:fix/set-validate-arguments
Open

reginaldalfret wants to merge 1 commit into
openai:mainfrom
reginaldalfret:fix/set-validate-arguments

Conversation

@reginaldalfret

Copy link
Copy Markdown

Summary

Similar to \Create.validate()\ (#1384) and \Push.validate()\ (#1380), \ art set\ now implements \�alidate()\ to catch invalid CLI options and argument errors before any filesystem or storage operations:

  • Local name validation: Ensures <name>\ is a local VM name (rejecting names containing /).
  • Option validation: Ensures --cpu, --memory, and --disk-size\ values are greater than zero if specified.
  • Mutual exclusion: Moves the --random-mac\ and --mac\ mutual exclusion check to \�alidate().

Tests

  • Added \ estSetRejectsInvalidArguments\ in \Tests/TartTests/CommandBehaviorTests.swift\ verifying rejection of non-local names, zero values for --cpu, --memory, --disk-size, and conflicting MAC flags.

Signed-off-by: reginaldalfret <reginaldalfret@gmail.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-24T12:03:32.779393Z
We couldn’t complete this review. Comment @codex review to try again.
5beb22b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant