Repository navigation
Trim whitespace around WWW-Authenticate directives - #1377
Merged
Merged
Conversation
RFC 7235 allows optional whitespace around the commas that separate auth-params, e.g. `Bearer realm="...", service="...", scope="..."`. The parser kept that whitespace in the keys, so "service" and "scope" were stored as " service" and " scope" and were never sent to the token endpoint.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
yzhuang-oai
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WWWAuthenticatesplits the challenge on commas but keeps the whitespace around each directive. RFC 7235 allows it (Bearer realm="...", service="...", scope="..."), and with that headerserviceandscopeend up stored as" service"and" scope".Registry.auththen looks them up by their plain names, so the token request goes out without them. With a space before a comma the value also keeps its closing quote.Now the key and the value are trimmed before the quotes are stripped. Added a parser test, and a
spacedmode toRegistryRealmTeststhat checks the token endpoint still receivesserviceandscope.Same bug as #1258, which was closed by its author without a fix.