Repository navigation
--net-host: use VZVmnetNetworkDeviceAttachment with VMNET_HOST_MODE - #1356
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 621f571414
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
yzhuang-oai
approved these changes
Sep 28, 2026
fkorotkov-oai
approved these changes
Sep 28, 2026
This was referenced Sep 30, 2026
herbygillot
added a commit
to herbygillot/macports-ports
that referenced
this pull request
Oct 3, 2026
Below macOS 26, compile out --net-host: 2.40.1 moved it to vmnet APIs that need the macOS 26 SDK, and upstream already rejects the flag at runtime there (openai/tart#1356). Generated-By: Dockhand v0.0.0-20260924.0.0.20261002213650-72b8d2924541 (https://github.com/herbygillot/dockhand) Assisted-by: Claude:claude-opus-5-5
6 of 11 tasks
herbygillot
added a commit
to macports/macports-ports
that referenced
this pull request
Oct 3, 2026
Below macOS 26, compile out --net-host: 2.40.1 moved it to vmnet APIs that need the macOS 26 SDK, and upstream already rejects the flag at runtime there (openai/tart#1356). Generated-By: Dockhand v0.0.0-20260924.0.0.20261002213650-72b8d2924541 (https://github.com/herbygillot/dockhand) Assisted-by: Claude:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of relying on Softnet, which has a more strict security model, see openai/softnet#209.