Repository navigation
orchard vnc: percent-encode credentials in the vnc:// URL - #525
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
yzhuang-oai
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
orchard vnc vmandorchard vnc workerformatted thevnc://URL withfmt.Sprintfand didn't escape the username and password. A password such asp/ssproducedvnc://admin:p/ss@127.0.0.1:<port>, which URL parsers read as hostadmin:p, so the VNC client couldn't connect.#and?move the rest of the URL into the fragment or the query.This change builds the URL with
net/url, so the credentials are percent-encoded. The printed (sanitized) URL and the existing behavior for empty credentials stay the same, except thatvmno longer adds a trailing:when the password is empty.Testing
go test -count=1 -v ./internal/command/vnc/:TestNewVNCURLandTestNewVNCURLEscapesCredentialspass. With the previous formatting logic,TestNewVNCURLEscapesCredentialsfails onp/ss.golangci-lint run ./internal/command/vnc/...(v2.14.0) reports no new issues.Fixes #524