Repository navigation
Return no match for invalid resource field paths - #517
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Resource-field lookup can panic instead of reporting a missing or unsupported field. Examples include continuing past a string (
name/field), inspecting an unexported time field (createdat/wall), and resolving a promoted field through a nil embedded pointer. The CLI uses this helper for VM, worker, and service-account field queries.Change
Check the reflection kind before field traversal, use FieldByIndexErr for promoted fields, and verify interface access before reading the result. Treat nil pointer/interface leaves as no match. Preserve case-insensitive field matching, supported nested fields, promoted fields, and Stringer values. No new map, slice-index, or pointer-traversal syntax is introduced.
The reflect documentation specifies the conditions under which these operations can panic.
Validation
git diff --checkpasses.Go 1.27.1 on macOS arm64. Tests use synthetic values and local fixtures, without contacting a controller or starting a VM. Go test executables and runtime temporary files used an automatically removed native temporary directory because this machine cannot execute them from the external exFAT workspace; source and dependency/build caches stayed external. No dependencies or public interfaces changed.
Reproduced against
f101ade5d8fdcad5e9c346472698649e7107a715.