Repository navigation
Use the path name when updating worker state - #516
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PUT /workers/{name}selects the worker using the JSON body's name instead of the path parameter. Omitting the redundant body name fails to update the requested worker, while a conflicting name can update a different worker. Even a nonexistent path succeeds when the body names an existing worker.Change
Use the path name for the store lookup, consistent with the worker GET/DELETE routes and VM updates. Preserve authorization, mutable fields, persisted identity, and transaction behavior. Matching path/body requests continue to work unchanged.
Validation
git diff --checkpasses.Go 1.27.1 on macOS arm64. No running controller, VM, external network, or real worker was used. No schema, dependency, or public API changes.
Reproduced against
f101ade5d8fdcad5e9c346472698649e7107a715.