Repository navigation
Honor cancelled callers during shared VM address lookups - #514
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The endpoint target dialer uses singleflight.Do for VM address resolution. A caller that joins an existing lookup cannot stop waiting when its own context expires. An already-cancelled caller also enters resolution before its context is checked.
Change
Wait on the shared result channel alongside the caller's cancellation signal. Check cancellation before starting resolution and before dialing. Retain lookup coalescing, uncached completed results, and the original first-caller context passed to the resolver; this does not redesign ownership of the shared lookup.
Validation
git diff --checkpassed. Hardware/runtime integration underinternal/testswas not run.The channel behavior follows the singleflight API. No dependencies or public interfaces change.
Reproduced against
f101ade5d8fdcad5e9c346472698649e7107a715.