Skip to content

telemetry: log structured tool and inference timing events#30942

Closed
bolinfest wants to merge 1 commit into
mainfrom
pr30942
Closed

telemetry: log structured tool and inference timing events#30942
bolinfest wants to merge 1 commit into
mainfrom
pr30942

Conversation

@bolinfest

@bolinfest bolinfest commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

External (non-OpenAI) Pull Request Requirements

External code contributions are by invitation only. Please read the dedicated "Contributing" markdown file for details:
https://github.com/openai/codex/blob/main/docs/contributing.md

If your PR conforms to our contribution guidelines, replace this text with a detailed and high quality description of your changes.

Include a link to a bug report or enhancement request.


Stack created with Sapling. Best reviewed with ReviewStack.

@bolinfest

Copy link
Copy Markdown
Collaborator Author

Closing this accidental intermediate PR created while updating #30334; the intended change remains in #30334.

@bolinfest bolinfest closed this Jul 2, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1adf6c71b0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +288 to +289
info!(
event.name = "codex.tool_call",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Route timing events through exported telemetry targets

When log export is enabled through OtelProvider, this new info! uses the module target (codex_core::tools::parallel), but OtelProvider::log_export_filter only exports codex_otel* targets, so codex.tool_call (and the matching codex.inference info! in turn_timing) will appear only in stderr JSON logs and be absent from configured OTel log exporters. Please emit these through SessionTelemetry/log_event! or another exported codex_otel target so the new timing telemetry reaches production log export.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant