Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1adf6c71b0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| info!( | ||
| event.name = "codex.tool_call", |
There was a problem hiding this comment.
Route timing events through exported telemetry targets
When log export is enabled through OtelProvider, this new info! uses the module target (codex_core::tools::parallel), but OtelProvider::log_export_filter only exports codex_otel* targets, so codex.tool_call (and the matching codex.inference info! in turn_timing) will appear only in stderr JSON logs and be absent from configured OTel log exporters. Please emit these through SessionTelemetry/log_event! or another exported codex_otel target so the new timing telemetry reaches production log export.
Useful? React with 👍 / 👎.
External (non-OpenAI) Pull Request Requirements
External code contributions are by invitation only. Please read the dedicated "Contributing" markdown file for details:
https://github.com/openai/codex/blob/main/docs/contributing.md
If your PR conforms to our contribution guidelines, replace this text with a detailed and high quality description of your changes.
Include a link to a bug report or enhancement request.
Stack created with Sapling. Best reviewed with ReviewStack.