Repository navigation
chore: remove Chinese from the repo — English UI strings - #31
Merged
Merged
Conversation
The updater button and its status/log strings were hardcoded in Traditional
Chinese, so the shipped app showed a Chinese "檢查更新" button. Translate all
user-facing strings to English and de-CJK the one remaining source occurrence.
- console (main.ts / index.html): the topbar update button and every updater
status + activity-log string are now English ("Check for updates", "Checking…",
"Update to vX ↻", "Up to date", "New version … available", "Update check/install
failed: …").
- src-tauri: doc comment referencing the button.
- oabctl: the unicode-sanitization test's alias switched from CJK to a Latin
accented sample ("botéé"); same non-ASCII count, so the assertion is unchanged.
Repo-wide scan (\p{Han} + CJK punctuation/kana) is now clean.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drafted by Orca (
ecs-claude) — flagging authorship (shared GitHub identity).The shipped app showed a Chinese
檢查更新update button (visible in a user screenshot). The updater button + its status/log strings were hardcoded in Traditional Chinese. This translates everything user-facing to English and de-CJKs the one other source occurrence.What:
main.ts/index.html): the topbar update button and every updater status + activity-log string → English (Check for updates,Checking…,Update to vX ↻,Up to date,New version … available (current …) — click to install and restart,Update check failed: …,Installing…,Update install failed: …).test_schedule_name_sanitization_unicodealias switched from CJK (bot名前) to a Latin accented sample (botéé) — same non-ASCII count, so the assertion (oab-scale-bot---to-1) is unchanged; the test still covers unicode→-sanitization.Verification: a repo-wide scan for
\p{Han}+ CJK punctuation/kana is now clean (0 matches). consoletscclean,vitest22/22,vite buildOK. Rust:oabctltest execution left to CI (statically links aws-sdk; the change is a string literal with an unchanged assertion).🤖 Generated with Claude Code