Repository navigation
docs: note Kiro API-key MCP issue and fix multibot thread-owner docs - #1585
chaodu-agent wants to merge 4 commits into
Conversation
- kiro.md: known-issue note for upstream kirodotdev/Kiro#11777 with tested GitHub OAuth workaround (#1576) - discord.md: allowed_role_ids table now matches MultibotMentions code; thread owner also needs @mention once another bot posted (#1566) Verification: docs-only; no local build (CI on PR).
This comment has been minimized.
This comment has been minimized.
… section - Known issue step 3: for Helm installs, also remove KIRO_API_KEY from agents.<name>.secretEnv, since the chart adds those keys to inherit_env. - API key section: link to the Known issue section for MCP/web tool failures. Checks: anchor #known-issue-mcp-and-web-tools-disabled-with-kiro_api_key verified against heading slug on macmini; no markdown lint workflow in repo.
- kiro.md: the Helm step said the chart adds secretEnv keys to inherit_env. The chart does not do that. Rewrite it to say the key is removed from agents.<name>.secretEnv (no container env injection) and must not be in inherit_env. - discord.md: mark the multibot-mentions thread-owner rule as current behavior tracked in #1566, which calls it a bug and may change. Rule itself unchanged. Checks: anchors #persisted-paths-pvc, #known-issue-mcp-and-web-tools-disabled-with-kiro_api_key, #multi-bot-setup resolve to headings on their pages. Repo has no markdownlint config or CI job, and markdownlint is not installed on macmini, so no lint run.
This comment has been minimized.
This comment has been minimized.
Step 3 said the agent subprocess only receives KIRO_API_KEY if inherit_env lists it. [agent].env also forwards it, so name both sources. Checks: docs-only; markdown anchors unchanged; diff touches only docs/kiro.md.
|
Note LGTM ✅ - The round-2 finding is fixed: workaround step 3 now names both What This PR DoesFixes two documentation gaps. How It Works
Findings
Finding Details🟢 F1: Step 3 env-forwarding sentence is now correct
🟢 F2: Discord docs match the codeIn 🟢 F3: Well-scoped temporary noteThe note links the upstream issue, names the tested CLI version (2.33.1), says to remove it once a fixed version is verified, and warns that 🟢 F4: Links, anchors, and CI#1566, #1576, and kirodotdev/Kiro#11777 return HTTP 200. Round 2 Findings Status
Follow-ups (outside this diff, non-blocking)
Reviewer Verdicts
Two reviewers did not report for this round; this aggregate is based on the reviews above. Inline Comments and External FeedbackNo inline review comments, submitted reviews, or comments from other users exist on this PR at the reviewed head, so there are no threads to answer or resolve. Baseline Check
5. Three Reasons We Might Not Need This PR
|
What problem does this solve?
Two documentation gaps reported by users:
docs/kiro.mdrecommendsKIRO_API_KEYauth, but an upstream Kiro bug (kiro-cli headless with API key: GetProfile returns "User is not authorized to access this feature", governance fails, MCP and web tools disabled (Pro, Google sign-in) kirodotdev/Kiro#11777, reproduced on Kiro CLI 2.33.1) can leave chat working while MCP servers and web tools are disabled. Users following the recommended path get no hint why.docs/discord.mdcontradicts itself aboutmultibot-mentions. Theallow_user_messagescomparison table (multi-bot thread, no @mention: no reply) matches the code, but theallowed_role_idssection says "Follow-up in the thread without @mention: Only the thread owner responds". Incrates/openab-core/src/discord.rs(AllowUsers::MultibotMentions), the thread owner is marked involved but still returns early when another bot has posted, so the owner also needs an @mention.Closes #1576
Refs #1566
Discord Discussion URL: Not applicable - maintainer docs fix for #1576 / #1566
Review Contract
Goal
docs/discord.mddescribe currentmultibot-mentionsbehavior consistently, including for the thread owner.Non-goals
AllowUsers::MultibotMentionsis unchanged.thread_owner_involvedsetting from bug(discord): thread owner stops answering un-mentioned messages in multibot-mentions threads (docs say it should) #1566; that stays open for a separate decision, which is why this PR uses "Refs bug(discord): thread owner stops answering un-mentioned messages in multibot-mentions threads (docs say it should) #1566" rather than closing it.Accepted Residual Risks
Acceptance Criteria
docs/kiro.mdAuthentication section has a known-issue note linking kiro-cli headless with API key: GetProfile returns "User is not authorized to access this feature", governance fails, MCP and web tools disabled (Pro, Google sign-in) kirodotdev/Kiro#11777, naming the affected version (2.33.1), and describing the GitHub OAuth workaround steps from docs: document Kiro API-key MCP failure and GitHub login workaround (upstream #11777) #1576.docs/discord.mdno longer claims the thread owner answers un-mentioned follow-ups in multi-bot threads; both sections agree withAllowUsers::MultibotMentionsindiscord.rs.Follow-ups
thread_owner_involvedproposal separately.At a Glance
N/A - docs-only change.
Prior Art & Industry Research
Not applicable - docs-only correction of existing behavior and an upstream known-issue note.
OpenClaw: Not applicable - docs-only.
Hermes Agent: Not applicable - docs-only.
Proposed Solution
docs/kiro.md: new "Known issue: MCP and web tools disabled withKIRO_API_KEY" subsection under the API key section, with log symptoms, the six workaround steps (device login withenv -u KIRO_API_KEY, verify "Logged in with GitHub", stop forwarding the key to the agent subprocess, persist~/.kiro/and~/.local/share/kiro-cli/, restart with a fresh session, verify a real tool call), and a diagnostics hint for nightly tags.docs/discord.md: themultibot-mentionsrow in theallow_user_messagestable now states the owner also needs an @mention once another bot posted; theallowed_role_idsinteraction table row is corrected, and a row for@Bot follow upis added.Why this approach?
The issue for #1566 itself offers this as the alternative if current behavior is kept. Fixing the docs to match the code is low-risk and removes the contradiction now, while the behavior change remains a separate product decision.
Alternatives Considered
thread_owner_involved(bug(discord): thread owner stops answering un-mentioned messages in multibot-mentions threads (docs say it should) #1566 proposal): a behavior/config change that needs maintainer decision; out of scope here.Validation
discord.mdwording againstAllowUsers::MultibotMentionsincrates/openab-core/src/discord.rs(owner path setsinvolved = truebut still returns whenother_botis true).#persisted-paths-pvcmatches the existing "Persisted Paths (PVC)" heading.