Repository navigation
ci(release): include a Review Contract in generated release PRs - #1569
Merged
Merged
Conversation
release-pr.yml created PRs with a one-line body, so the Review Contract check failed on every release PR (beta.5 #1549, beta.6 #1568) and was merged red. Generate a body with all required sections instead of relying on the review-contract-exempt label, which docs reserve for an explicit maintainer decision.
4 tasks
thepagent
pushed a commit
that referenced
this pull request
Oct 23, 2026
…ndow (#1573) GitHub delivers the hourly schedule every ~4-5h, so the 'commit in the last ~70min' gate skipped most merges. The last full pre-beta build was 99c11ec (2026-10-03); #1562, #1564, #1568 and #1569 never reached pre-beta-*, which also kept downstream openab-pty images on Node 22.23.3. Build when main HEAD differs from the head SHA of the last successful run that tagged every agent. Co-authored-by: chaodu-agent <274062505+chaodu-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this solve?
release-pr.ymlcreates release PRs with a one-line body, so theReview Contractcheck (validate) fails on every release PR. Both #1549 (beta.5) and #1568 (beta.6) were merged with a red check, which trains reviewers to ignore it.This PR changes the workflow to generate a body with every required Review Contract section, so release PRs pass validation.
Review Contract
Goal
Release PRs created by
release-pr.ymlpassreview-contract.ymlwithout a maintainer exemption.Non-goals
review-contract-exemptlabel and no automatic exemption.docs/review-contract.mdreserves exemption for an explicit, documented maintainer decision, so a workflow should not apply it automatically. The label also does not exist in the repo today.Accepted Residual Risks
Acceptance Criteria
## Review Contractplus Goal, Non-goals, Accepted Residual Risks, Acceptance Criteria, and Follow-ups, in that order.perl .github/scripts/review_contract.plpasses on the generated body for both a beta version (0.10.0-beta.7) and a stable version (0.10.0).Merge this PR to tag `v<version>` and trigger the build pipeline.STABLEis passed into the step, so the Goal states the correctCargo.tomlversion.Follow-ups
validateis green on the next Release PR (0.10.0, planned for 2026-10-30 per RFC: rebuild agent images for Node.js security releases (Node 22.23.4 / 24.22.1) #1567).Changes
Create release PRstep writes the body to a temp file with a heredoc and passes it with--body-file.STABLEis added to the step env, becauseCargo.tomlgets the stable version whileChart.yamlgets the full version.Validation
The heredoc was extracted from the workflow, de-indented the way YAML does it, and run:
VERSION=0.10.0-beta.7 STABLE=0.10.0→Review Contract validation passedVERSION=0.10.0 STABLE=0.10.0→Review Contract validation passedperl .github/scripts/test_review_contract.pl→ passedDiscord Discussion URL: https://discord.com/channels/1490282656913559673/1562951633544020000