You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
cp: enforce MIN_RUNTIME_FRAME_BYTES with its first consumer and document the breaking config floor #1590
#1588 adds pub const MIN_RUNTIME_FRAME_BYTES: usize = 1024 * 1024; in crates/openab-cp/src/proto.rs. Nothing uses it yet: there is no consumer, no enforcement and no test. Its doc comment says CP config validation will start rejecting smaller max_frame_bytes values in the runtime-client PR (PR B of the #1528 split).
Once that lands, an existing CP config with max_frame_bytes below 1 MiB, which validates today, will fail validation after upgrade. That is a breaking config change.
Proposed fix (in the runtime-client PR)
Add the validate() floor for max_frame_bytes >= MIN_RUNTIME_FRAME_BYTES together with its first consumer (the runtime client).
Thanks for the report! A maintainer will triage this shortly and apply the appropriate label. Once a type label is added, the issue will be re-validated automatically.
Activity
github-actions commentedon Oct 30, 2026
Thanks for the report! A maintainer will triage this shortly and apply the appropriate label. Once a type label is added, the issue will be re-validated automatically.