Repository navigation
docs: point reverse-attach links at openab-computer after rename - #82
chaodu-agent wants to merge 1 commit into
Conversation
|
Important CHANGES REQUESTED What This PR DoesThe How It WorksThe PR is one commit that changes one line in each of 7 files (7 insertions, 7 deletions). All changes are in Markdown, Rust
Findings
Finding Details🟡 F1: Commit message describes a change that is not in the diffThe body of commit The diff for Verified by the coordinator with Suggested fix: Reword the line to 🟢 F2: Repository references are complete
🟢 F3: Fixed identifiers are preservedThe diff leaves unchanged the 🟢 F4: Prose rename is accurateThe old comments used the bare repository name Reviewer Verdicts
The coordinator reproduced F1 against the head SHA, so it stays at 🟡. Reviewer A did not report it; its file-content checks agree with F2 to F4. No findings were dropped or downgraded. Addressing External Reviewer FeedbackNo external review comments or GitHub reviews exist on this PR at the time of this round. 5. Three Reasons We Might Not Need This PR
Baseline Check
What's Good (🟢)
|
The instance-mcp repository was renamed to openabdev/openab-computer. This commit retargets the reverse-attach ADR references to the new name and changes three prose comments to say "OpenAB Computer". Changes, 7 files, 1 insertion and 1 deletion each: - README.md:100: reverse-attach ADR link now points at openabdev/openab-computer. - docs/k8s-howto.md:152: same ADR link retargeted. - runtime/CLIENT-CONTRACT.md:286: same ADR link retargeted. Only the link changes in section 9; the surrounding prose is not modified. - runtime/src/tools.rs:5: module doc comment ADR reference now names openabdev/openab-computer. - Dockerfile:120: comment prose "instance-mcp tools" -> "OpenAB Computer tools". - deploy/ecs/entrypoint.sh:74: comment prose -> "OpenAB Computer tools". - deploy/k8s/pod-tailscale.yaml:110: comment prose -> "OpenAB Computer". Not changed: executable oab-instance-mcp, bundle id dev.openab.instance-mcp, config and log paths, LaunchAgent labels, release asset names, and docs/adr/ files. No build or test was run; the diff touches only comments, docs, and GitHub URLs.
083a628 to
d3e6a4c
Compare
|
Note LGTM ✅ - The seven one-line doc and comment changes retarget the reverse-attach links to openabdev/openab-computer, and the rewritten commit message now describes the diff exactly. What This PR DoesThe instance-mcp repository was renamed to openabdev/openab-computer. This PR updates the links and prose comments in this repo that still pointed at the old name, so readers land on the right repository. How It WorksSeven files change by one line each. Four lines retarget the reverse-attach ADR link or repository reference to Findings
Finding Details🟢 F1: Previous-round blocker fixedThe previous review (on 🟢 F2: Metadata-only rewrite
🟢 F3: Scope limited to links and proseThe removed lines mention 🟢 F4: Accurate commit message"7 files, 1 insertion and 1 deletion each" matches Reviewer Verdicts
Three Reasons We Might Not Need This PR
The redirect can break if a new repository ever takes the old name, and the fixed identifiers are kept on purpose for compatibility, so the PR is still worth merging. Baseline Check
Reviewers: Reviewer A and Reviewer B |
This PR updates the reverse-attach documentation links after the rename of the
instance-mcp repository to openab-computer.
Changes:
openabdev/openab-computer in README.md, docs/k8s-howto.md,
runtime/CLIENT-CONTRACT.md and the module doc comment in runtime/src/tools.rs.
deploy/k8s/pod-tailscale.yaml so they name OpenAB Computer instead of
instance-mcp.
No commands, paths, identifiers, binary names or release asset names change.
Docs and comments only, so no build or test run is needed for this change.
Refs openabdev/openab-computer#63
Discord Discussion URL: Not applicable - maintainer-filed rename docs step tracked in openabdev/openab-computer#63.