Skip to content

Refactor extra meters not in hierarchy: remove unused code - #1107

Merged
LKuemmel merged 2 commits into
openWB:mainfrom
LKuemmel:loadmanagement_prio_list
Sep 29, 2026
Merged

LKuemmel merged 2 commits into
openWB:mainfrom
LKuemmel:loadmanagement_prio_list

Conversation

@LKuemmel

@LKuemmel LKuemmel commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

openWB/core#4011 entfernt die Einträge von verknüpften Zählern in der Struktur, damit ist eine Filterung im UI nicht mehr nötig.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review issues were identified.

Review effort: Lite
Findings: None

What changed in this PR

Refactors extra-meter link handling by removing unused hierarchy-hiding logic while preserving linked meter labels.

Changes:

  • Removes the unused hidden-ids binding and computed property.
  • Inlines extra-meter link collection.
File Description
src/​views/​LoadManagementConfiguration.vue Simplifies extra-meter handling and removes obsolete hiding support.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@Brett-S-OWB

Copy link
Copy Markdown
Contributor

Da core #4011 verknüpfte Zähler aus der Hierarchie entfernt, wird das hiddenIds-Handling in den beiden Listen-Komponenten jetzt ebenfalls nicht mehr benötigt. hidden-ids wird nirgends mehr übergeben. Könntest du das in diesem PR bitte auch noch entfernen?

src/components/OpenwbSortableList.vue

Zeile 30: :hidden-ids="hiddenIds" entfernen
Zeile 58: die Prop hiddenIds: { type: Array, default: undefined }, entfernen

src/components/OpenwbNestedList.vue

Zeile 11:

  • →

  • Zeile 75: :hidden-ids="hiddenIds" an der verschachtelten openwb-nested-list entfernen
    Zeile 135: die Prop hiddenIds: { type: Array, required: false, default: undefined }, entfernen
    Zeilen 220–222: die Methode isHidden(element) entfernen

    src/views/LoadManagementConfiguration.vue

    Zeile 451: die Leerzeile enthält Leerzeichen am Zeilenende

  • @LKuemmel
    LKuemmel force-pushed the loadmanagement_prio_list branch from 49c34e6 to f4a5e20 Compare September 29, 2026 09:20
    @LKuemmel
    LKuemmel merged commit e27239b into openWB:main Sep 29, 2026
    1 check passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants