Skip to content

consumer rfid - #4170

Open
LKuemmel wants to merge 1 commit into
feature_refactor_internal_chargepoint_handlerfrom
feature_consumer_rfid
Open

LKuemmel wants to merge 1 commit into
feature_refactor_internal_chargepoint_handlerfrom
feature_consumer_rfid

Conversation

@LKuemmel

Copy link
Copy Markdown
Contributor

No description provided.

@LKuemmel
LKuemmel added this pull request to stack #4171 October 22, 2026 10:42
@LKuemmel
LKuemmel force-pushed the feature_consumer_rfid branch 2 times, most recently from 3ceb62d to dd95f20 Compare October 23, 2026 08:44
@LKuemmel
LKuemmel requested a lite review from Copilot October 23, 2026 09:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Consumer usage transitions can retain stale RFID authorization, and a parameterized store test fails with a missing call import.

2 open issues
What changed in this PR

Adds end-to-end RFID authorization support for MQTT consumers, including tag acquisition, validation, expiry, reset behavior, state publication, and configuration handling.

Changes:

  • Adds RFID configuration, runtime state, authorization, timeout, and reset logic.
  • Extends MQTT consumers and stores to receive, publish, and clear RFID data.
  • Refactors internal chargepoint client context management and updates RFID messaging.
File Description
packages/​modules/​internal_chargepoint_handler/​internal_chargepoint_handler.py Uses ExitStack to manage unique client contexts.
packages/​modules/​consumers/​generic/​mqtt/​consumer.py Adds MQTT RFID parsing and clearing.
packages/​modules/​consumers/​generic/​mqtt/​consumer_test.py Tests MQTT RFID state handling and clearing.
packages/​modules/​common/​store/​_consumer.py Publishes consumer RFID state to broker topics.
packages/​modules/​common/​store/​_consumer_test.py Tests RFID state forwarding.
packages/​modules/​common/​configurable_consumer.py Adds the configurable RFID-clear callback.
packages/​modules/​common/​component_state.py Extends consumer state with RFID fields.
packages/​helpermodules/​update_config.py Registers consumer RFID topics.
packages/​helpermodules/​setdata.py Adds validation for consumer RFID topics and values.
packages/​control/​consumer/​rfid.py Implements RFID authorization and expiration logic.
packages/​control/​consumer/​rfid_test.py Tests RFID authorization, reset, and timeout behavior.
packages/​control/​consumer/​consumer.py Integrates RFID processing into the consumer control loop.
packages/​control/​consumer/​consumer_data.py Adds RFID configuration and runtime data fields.
packages/​control/​chargepoint/​rfid.py Updates an RFID assignment error message.

Review effort: Lite

Comment thread packages/control/consumer/consumer.py Outdated
return
else:
self.reset_chargemode_at_time()
self.update_rfid()
Comment on lines +1 to +3
import pytest

from modules.common.component_state import ConsumerState
@LKuemmel
LKuemmel force-pushed the feature_consumer_rfid branch from 8f0598f to e1f21e2 Compare October 23, 2026 12:55
@LKuemmel
LKuemmel force-pushed the feature_consumer_rfid branch from 2e1d47b to 3d467b1 Compare October 23, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants