Repository navigation
consumer rfid - #4170
Open
LKuemmel wants to merge 1 commit into
Open
consumer rfid#4170LKuemmel wants to merge 1 commit into
LKuemmel wants to merge 1 commit into
Conversation
LKuemmel
added this pull request to stack #4171
October 22, 2026 10:42
LKuemmel
force-pushed
the
feature_consumer_rfid
branch
2 times, most recently
from
October 23, 2026 08:44
3ceb62d to
dd95f20
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Consumer usage transitions can retain stale RFID authorization, and a parameterized store test fails with a missing call import.
2 open issues
What changed in this PR
Adds end-to-end RFID authorization support for MQTT consumers, including tag acquisition, validation, expiry, reset behavior, state publication, and configuration handling.
Changes:
- Adds RFID configuration, runtime state, authorization, timeout, and reset logic.
- Extends MQTT consumers and stores to receive, publish, and clear RFID data.
- Refactors internal chargepoint client context management and updates RFID messaging.
| File | Description |
|---|---|
packages/modules/internal_chargepoint_handler/internal_chargepoint_handler.py |
Uses ExitStack to manage unique client contexts. |
packages/modules/consumers/generic/mqtt/consumer.py |
Adds MQTT RFID parsing and clearing. |
packages/modules/consumers/generic/mqtt/consumer_test.py |
Tests MQTT RFID state handling and clearing. |
packages/modules/common/store/_consumer.py |
Publishes consumer RFID state to broker topics. |
packages/modules/common/store/_consumer_test.py |
Tests RFID state forwarding. |
packages/modules/common/configurable_consumer.py |
Adds the configurable RFID-clear callback. |
packages/modules/common/component_state.py |
Extends consumer state with RFID fields. |
packages/helpermodules/update_config.py |
Registers consumer RFID topics. |
packages/helpermodules/setdata.py |
Adds validation for consumer RFID topics and values. |
packages/control/consumer/rfid.py |
Implements RFID authorization and expiration logic. |
packages/control/consumer/rfid_test.py |
Tests RFID authorization, reset, and timeout behavior. |
packages/control/consumer/consumer.py |
Integrates RFID processing into the consumer control loop. |
packages/control/consumer/consumer_data.py |
Adds RFID configuration and runtime data fields. |
packages/control/chargepoint/rfid.py |
Updates an RFID assignment error message. |
Review effort: Lite
| return | ||
| else: | ||
| self.reset_chargemode_at_time() | ||
| self.update_rfid() |
Comment on lines
+1
to
+3
| import pytest | ||
|
|
||
| from modules.common.component_state import ConsumerState |
LKuemmel
force-pushed
the
feature_consumer_rfid
branch
from
October 23, 2026 12:55
8f0598f to
e1f21e2
Compare
LKuemmel
force-pushed
the
feature_consumer_rfid
branch
from
October 23, 2026 14:11
2e1d47b to
3d467b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.